]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
mroute: "ip mroute show" not working when "to" and/or "from" is given
authorMazhar Rana <ranamazharp@gmail.com>
Thu, 11 Jun 2015 16:07:36 +0000 (21:37 +0530)
committerStephen Hemminger <shemming@brocade.com>
Thu, 25 Jun 2015 12:47:07 +0000 (08:47 -0400)
The command "ip mroute show" is not showing routes when "to" and/or "from"
filter is applied.

root@mazhar:~# ip mroute show
(10.202.30.101, 235.1.2.3)       Iif: eth0       Oifs: eth1

But When I applied filter, it does not show anything.

root@mazhar:~# ip mroute show 235.1.2.3 from 10.202.30.101
root@mazhar:~#

Signed-off-by: Mazhar Rana <ranamazharp@gmail.com>
ip/ipmroute.c

index 125a13f8c58236590df26ac19f33a758ed2f8c75..fffa9e2c77466d6d8cd6c576dbb2f1b4e37820af 100644 (file)
@@ -97,15 +97,25 @@ int print_mroute(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
        if (filter.af && filter.af != r->rtm_family)
                return 0;
 
-       if (tb[RTA_DST] &&
-           filter.mdst.bitlen > 0 &&
-           inet_addr_match(RTA_DATA(tb[RTA_DST]), &filter.mdst, filter.mdst.bitlen))
-               return 0;
+       if (tb[RTA_DST] && filter.mdst.bitlen > 0) {
+               inet_prefix dst;
+
+               memset(&dst, 0, sizeof(dst));
+               dst.family = r->rtm_family;
+               memcpy(&dst.data, RTA_DATA(tb[RTA_DST]), RTA_PAYLOAD(tb[RTA_DST]));
+               if (inet_addr_match(&dst, &filter.mdst, filter.mdst.bitlen))
+                       return 0;
+       }
 
-       if (tb[RTA_SRC] &&
-           filter.msrc.bitlen > 0 &&
-           inet_addr_match(RTA_DATA(tb[RTA_SRC]), &filter.msrc, filter.msrc.bitlen))
-               return 0;
+       if (tb[RTA_SRC] && filter.msrc.bitlen > 0) {
+               inet_prefix src;
+
+               memset(&src, 0, sizeof(src));
+               src.family = r->rtm_family;
+               memcpy(&src.data, RTA_DATA(tb[RTA_SRC]), RTA_PAYLOAD(tb[RTA_SRC]));
+               if (inet_addr_match(&src, &filter.msrc, filter.msrc.bitlen))
+                       return 0;
+       }
 
        family = r->rtm_family == RTNL_FAMILY_IPMR ? AF_INET : AF_INET6;