upstream commit

fix free() of uninitialised pointer reported by Mateusz
 Kocielski; ok markus@

Upstream-ID: 519552b050618501a06b7b023de5cb104e2c5663

diff --git a/mux.c b/mux.c
index cdc01bd4fff5f3a19798f0b89b5abd4c49a28e93..e6136fd28c2892181aef998e42b06d64d0532895 100644 (file)
--- a/mux.c
+++ b/mux.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: mux.c,v 1.53 2015/05/01 04:03:20 djm Exp $ */
+/* $OpenBSD: mux.c,v 1.54 2015/08/19 23:18:26 djm Exp $ */
 /*
  * Copyright (c) 2002-2008 Damien Miller <djm@openbsd.org>
  *
@@ -665,6 +665,8 @@ process_mux_open_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
        u_int lport, cport;
        int i, ret = 0, freefwd = 1;
 
+       memset(&fwd, 0, sizeof(fwd));
+
        /* XXX - lport/cport check redundant */
        if (buffer_get_int_ret(&ftype, m) != 0 ||
            (listen_addr = buffer_get_string_ret(m, NULL)) == NULL ||
@@ -832,6 +834,8 @@ process_mux_close_fwd(u_int rid, Channel *c, Buffer *m, Buffer *r)
        int i, ret = 0;
        u_int lport, cport;
 
+       memset(&fwd, 0, sizeof(fwd));
+
        if (buffer_get_int_ret(&ftype, m) != 0 ||
            (listen_addr = buffer_get_string_ret(m, NULL)) == NULL ||
            buffer_get_int_ret(&lport, m) != 0 ||