JS: remove unused variables.

diff --git a/docs/assets/js/_src/application.js b/docs/assets/js/_src/application.js
index 678c6eace4a05fdb928af573abeb379caa49265c..9ebba13fe554d3f32e9a432ba46150b597270bc0 100644 (file)
--- a/docs/assets/js/_src/application.js
+++ b/docs/assets/js/_src/application.js
@@ -31,11 +31,8 @@
     var $window = $(window)
     var $body   = $(document.body)
 
-    var navHeight = $('.navbar').outerHeight(true) + 10
-
     $body.scrollspy({
-      target: '.bs-docs-sidebar',
-      // offset: navHeight
+      target: '.bs-docs-sidebar'
     })
 
     $window.on('load', function () {

diff --git a/docs/assets/js/_src/customizer.js b/docs/assets/js/_src/customizer.js
index c2dcba73f4a32f15282a2dcac40fb932e1a5f975..ac314dc7337896b93311d87e846dd048ab8a2dca 100644 (file)
--- a/docs/assets/js/_src/customizer.js
+++ b/docs/assets/js/_src/customizer.js
@@ -231,7 +231,9 @@ window.onload = function () { // wait for load in a dumb way because B-0
       paths: ['variables.less', 'mixins.less'],
       optimization: 0,
       filename: baseFilename + '.css'
-    }).parse(lessSource, function (err, tree) {
+    })
+
+    parser.parse(lessSource, function (err, tree) {
       if (err) {
         return showError('<strong>Ruh roh!</strong> Could not parse less files.', err)
       }
@@ -331,7 +333,6 @@ window.onload = function () { // wait for load in a dumb way because B-0
   })
 
   var $compileBtn = $('#btn-compile')
-  var $downloadBtn = $('#btn-download')
 
   $compileBtn.on('click', function (e) {
     var configData = getCustomizerData()

diff --git a/grunt/.jshintrc b/grunt/.jshintrc
index 8d402b53c2a6613e5047db5e7dc9122e2dfde139..d9dce889b11e5dd885a1adc6384c3275ee7d2062 100644 (file)
--- a/grunt/.jshintrc
+++ b/grunt/.jshintrc
@@ -6,5 +6,6 @@
   "node"  : true,
   "nonbsp": true,
   "strict": true,
-  "undef" : true
+  "undef" : true,
+  "unused": true
 }

diff --git a/js/.jshintrc b/js/.jshintrc
index e1ead322ea470d7c3072ed819b6fc4ebac47e169..c6104dc931347b5de85f663307df64e18e736fcc 100644 (file)
--- a/js/.jshintrc
+++ b/js/.jshintrc
@@ -8,5 +8,6 @@
   "eqnull"   : true,
   "expr"     : true,
   "laxbreak" : true,
+  "unused"   : true,
   "validthis": true
 }

diff --git a/js/scrollspy.js b/js/scrollspy.js
index 137bd373fc964549568a6e5e7daaeca7a88ab676..c77a9fbed7140c41f4a6a1823d5bdaaa6726b9e0 100644 (file)
--- a/js/scrollspy.js
+++ b/js/scrollspy.js
@@ -43,7 +43,8 @@
     this.targets = $([])
 
     var self     = this
-    var $targets = this.$body
+
+    this.$body
       .find(this.selector)
       .map(function () {
         var $el   = $(this)

diff --git a/js/tests/unit/affix.js b/js/tests/unit/affix.js
index b348ecf2b5a19371d624484f8c200924b7bb8840..673026b8c1d91cbfb05a5b91e4f2719a87ec8f04 100644 (file)
--- a/js/tests/unit/affix.js
+++ b/js/tests/unit/affix.js
@@ -28,14 +28,14 @@ $(function () {
     var template = $('<div id="affixTarget"><ul><li>Please affix</li><li>And unaffix</li></ul></div><div id="affixAfter" style="height: 20000px; display:block;"></div>')
     template.appendTo('body')
 
-    var affixer = $('#affixTarget').affix({
+    $('#affixTarget').affix({
       offset: $('#affixTarget ul').position()
     })
 
     $('#affixTarget')
-      .on('affix.bs.affix', function (e) {
+      .on('affix.bs.affix', function () {
         ok(true, 'affix event triggered')
-      }).on('affixed.bs.affix', function (e) {
+      }).on('affixed.bs.affix', function () {
         ok(true,'affixed event triggered')
         $('#affixTarget').remove()
         $('#affixAfter').remove()

diff --git a/js/tests/unit/button.js b/js/tests/unit/button.js
index 73420863ce8f2f51293c85d19d29e908ce459e66..ea1236478837b03ac08dc832638c01206b8ee52b 100644 (file)
--- a/js/tests/unit/button.js
+++ b/js/tests/unit/button.js
@@ -98,7 +98,6 @@ $(function () {
 
     var btn1 = $(group.children()[0])
     var btn2 = $(group.children()[1])
-    var btn3 = $(group.children()[2])
 
     group.appendTo($('#qunit-fixture'))
 

diff --git a/js/tests/unit/collapse.js b/js/tests/unit/collapse.js
index 7948b3ab49c1d32d34d7e6e1d824b9fa478471b7..bead36f91d59a067adf093166611f83473cec9bf 100644 (file)
--- a/js/tests/unit/collapse.js
+++ b/js/tests/unit/collapse.js
@@ -64,7 +64,7 @@ $(function () {
     var target = $('<a data-toggle="collapse" href="#test1"></a>')
       .appendTo($('#qunit-fixture'))
 
-    var collapsible = $('<div id="test1"></div>')
+    $('<div id="test1"></div>')
       .appendTo($('#qunit-fixture'))
       .on('show.bs.collapse', function () {
         ok(!target.hasClass('collapsed'))
@@ -81,7 +81,7 @@ $(function () {
     var target = $('<a data-toggle="collapse" href="#test1"></a>')
       .appendTo($('#qunit-fixture'))
 
-    var collapsible = $('<div id="test1" class="in"></div>')
+    $('<div id="test1" class="in"></div>')
       .appendTo($('#qunit-fixture'))
       .on('hide.bs.collapse', function () {
         ok(target.hasClass('collapsed'))
@@ -101,19 +101,19 @@ $(function () {
     var target1 = $('<a data-toggle="collapse" href="#body1" data-parent="#accordion"></a>')
       .appendTo(accordion.find('.accordion-group').eq(0))
 
-    var collapsible1 = $('<div id="body1" class="in"></div>')
+    $('<div id="body1" class="in"></div>')
       .appendTo(accordion.find('.accordion-group').eq(0))
 
     var target2 = $('<a class="collapsed" data-toggle="collapse" href="#body2" data-parent="#accordion"></a>')
       .appendTo(accordion.find('.accordion-group').eq(1))
 
-    var collapsible2 = $('<div id="body2"></div>')
+    $('<div id="body2"></div>')
       .appendTo(accordion.find('.accordion-group').eq(1))
 
     var target3 = $('<a class="collapsed" data-toggle="collapse" href="#body3" data-parent="#accordion"></a>')
       .appendTo(accordion.find('.accordion-group').eq(2))
 
-    var collapsible3 = $('<div id="body3"></div>')
+    $('<div id="body3"></div>')
       .appendTo(accordion.find('.accordion-group').eq(2))
       .on('show.bs.collapse', function () {
         ok(target1.hasClass('collapsed'))
@@ -136,19 +136,19 @@ $(function () {
     var target1 = $('<a data-toggle="collapse" href="#body1" data-parent=".accordion"></a>')
       .appendTo(accordion.find('.accordion-group').eq(0))
 
-    var collapsible1 = $('<div id="body1" class="in"></div>')
+    $('<div id="body1" class="in"></div>')
       .appendTo(accordion.find('.accordion-group').eq(0))
 
     var target2 = $('<a class="collapsed" data-toggle="collapse" href="#body2" data-parent=".accordion"></a>')
       .appendTo(accordion.find('.accordion-group').eq(1))
 
-    var collapsible2 = $('<div id="body2"></div>')
+    $('<div id="body2"></div>')
       .appendTo(accordion.find('.accordion-group').eq(1))
 
     var target3 = $('<a class="collapsed" data-toggle="collapse" href="#body3" data-parent=".accordion"></a>')
       .appendTo(accordion.find('.accordion-group').eq(2))
 
-    var collapsible3 = $('<div id="body3"></div>')
+    $('<div id="body3"></div>')
       .appendTo(accordion.find('.accordion-group').eq(2))
       .on('show.bs.collapse', function () {
         ok(target1.hasClass('collapsed'))

diff --git a/js/tests/unit/scrollspy.js b/js/tests/unit/scrollspy.js
index d91b6b313179b18fc59a79330e70068a1895fbe4..670735a4682de6ed69af57709267684379e49bd0 100644 (file)
--- a/js/tests/unit/scrollspy.js
+++ b/js/tests/unit/scrollspy.js
@@ -18,7 +18,6 @@ $(function () {
 
   test('should switch active class on scroll', function () {
     var sectionHTML = '<div id="masthead"></div>',
-        $section = $(sectionHTML).append('#qunit-fixture'),
         topbarHTML = '<div class="topbar">' +
         '<div class="topbar-inner">' +
         '<div class="container">' +
@@ -30,6 +29,7 @@ $(function () {
         '</div>',
         $topbar = $(topbarHTML).scrollspy()
 
+    $(sectionHTML).append('#qunit-fixture')
     ok($topbar.find('.active', true))
   })
 

diff --git a/js/tests/unit/tooltip.js b/js/tests/unit/tooltip.js
index e670883e358beb452657cd4331650afade2dd6c6..e6ae11993093ef56a7186b19dc0a9c36209a332f 100644 (file)
--- a/js/tests/unit/tooltip.js
+++ b/js/tests/unit/tooltip.js
@@ -68,7 +68,7 @@ $(function () {
 
   test('should fire show event', function () {
     stop()
-    var tooltip = $('<div title="tooltip title"></div>')
+    $('<div title="tooltip title"></div>')
       .on('show.bs.tooltip', function () {
         ok(true, 'show was called')
         start()
@@ -78,7 +78,7 @@ $(function () {
 
   test('should fire shown event', function () {
     stop()
-    var tooltip = $('<div title="tooltip title"></div>')
+    $('<div title="tooltip title"></div>')
       .on('shown.bs.tooltip', function () {
         ok(true, 'shown was called')
         start()
@@ -88,7 +88,7 @@ $(function () {
 
   test('should not fire shown event when default prevented', function () {
     stop()
-    var tooltip = $('<div title="tooltip title"></div>')
+    $('<div title="tooltip title"></div>')
       .on('show.bs.tooltip', function (e) {
         e.preventDefault()
         ok(true, 'show was called')
@@ -102,7 +102,7 @@ $(function () {
 
   test('should fire hide event', function () {
     stop()
-    var tooltip = $('<div title="tooltip title"></div>')
+    $('<div title="tooltip title"></div>')
       .on('shown.bs.tooltip', function () {
         $(this).tooltip('hide')
       })
@@ -115,7 +115,7 @@ $(function () {
 
   test('should fire hidden event', function () {
     stop()
-    var tooltip = $('<div title="tooltip title"></div>')
+    $('<div title="tooltip title"></div>')
       .on('shown.bs.tooltip', function () {
         $(this).tooltip('hide')
       })
@@ -128,7 +128,7 @@ $(function () {
 
   test('should not fire hidden event when default prevented', function () {
     stop()
-    var tooltip = $('<div title="tooltip title"></div>')
+    $('<div title="tooltip title"></div>')
       .on('shown.bs.tooltip', function () {
         $(this).tooltip('hide')
       })
@@ -272,14 +272,14 @@ $(function () {
 
   test('should show tooltip with delegate selector on click', function () {
     var div = $('<div><a href="#" rel="tooltip" title="Another tooltip"></a></div>')
-    var tooltip = div.appendTo('#qunit-fixture')
+    div.appendTo('#qunit-fixture')
                      .tooltip({ selector: 'a[rel=tooltip]', trigger: 'click' })
     div.find('a').trigger('click')
     ok($('.tooltip').is('.fade.in'), 'tooltip is faded in')
   })
 
   test('should show tooltip when toggle is called', function () {
-    var tooltip = $('<a href="#" rel="tooltip" title="tooltip on toggle"></a>')
+    $('<a href="#" rel="tooltip" title="tooltip on toggle"></a>')
       .appendTo('#qunit-fixture')
       .tooltip({trigger: 'manual'})
       .tooltip('toggle')
@@ -298,8 +298,8 @@ $(function () {
 
   test('should place tooltip inside window', function () {
     var container = $('<div />').appendTo('body')
-        .css({position: 'absolute', width: 200, height: 200, bottom: 0, left: 0}),
-        tooltip = $('<a href="#" title="Very very very very very very very very long tooltip">Hover me</a>')
+        .css({position: 'absolute', width: 200, height: 200, bottom: 0, left: 0})
+    $('<a href="#" title="Very very very very very very very very long tooltip">Hover me</a>')
       .css({position: 'absolute', top: 0, left: 0})
       .appendTo(container)
       .tooltip({placement: 'top', animate: false})

diff --git a/js/tooltip.js b/js/tooltip.js
index f27beacc6da0f57d5062e589a0f9ee2b283aed8e..bb47d4336588bc5dbad0deb292d5c5750a908127 100644 (file)
--- a/js/tooltip.js
+++ b/js/tooltip.js
@@ -195,7 +195,6 @@
   }
 
   Tooltip.prototype.applyPlacement = function (offset, placement) {
-    var replace
     var $tip   = this.tip()
     var width  = $tip[0].offsetWidth
     var height = $tip[0].offsetHeight