Use strict prototypes

Function declarations with no argument declare functions taking an
arbitrary number of arguments. Use the special type void to declare
functions taking no argument.

diff --git a/lib/nss.c b/lib/nss.c
index d1419f34657e9324c845a59bed2d641dc128cc26..96364b76a283e1373a4e33d08ee19df55a907c5c 100644 (file)
--- a/lib/nss.c
+++ b/lib/nss.c
@@ -29,7 +29,7 @@ bool nss_is_initialized() {
        return atomic_load(&nss_init_completed);
 }
 
-static void nss_exit() {
+static void nss_exit(void) {
        if (nss_is_initialized() && subid_nss) {
                dlclose(subid_nss->handle);
                free(subid_nss);

diff --git a/lib/prototypes.h b/lib/prototypes.h
index 6f80df8287d1b3e05fac069042c133582da6aefc..43f0cf1d57ab03dc34bd3cf3d6140912ad5b4bb8 100644 (file)
--- a/lib/prototypes.h
+++ b/lib/prototypes.h
@@ -164,7 +164,7 @@ extern int getrange (char *range,
                      unsigned long *max, bool *has_max);
 
 /* gettime.c */
-extern time_t gettime ();
+extern time_t gettime (void);
 
 /* get_uid.c */
 extern int get_uid (const char *uidstr, uid_t *uid);
@@ -243,7 +243,7 @@ extern /*@null@*//*@only@*/struct passwd *get_my_pwent (void);
 /* nss.c */
 #include <libsubid/subid.h>
 extern void nss_init(char *nsswitch_path);
-extern bool nss_is_initialized();
+extern bool nss_is_initialized(void);
 
 struct subid_nss_ops {
        /*
@@ -293,7 +293,7 @@ struct subid_nss_ops {
        void *handle;
 };
 
-extern struct subid_nss_ops *get_subid_nss_handle();
+extern struct subid_nss_ops *get_subid_nss_handle(void);
 
 
 /* pam_pass_non_interactive.c */
@@ -324,12 +324,12 @@ extern struct passwd *prefix_getpwuid(uid_t uid);
 extern struct passwd *prefix_getpwnam(const char* name);
 extern struct spwd *prefix_getspnam(const char* name);
 extern struct group *prefix_getgr_nam_gid(const char *grname);
-extern void prefix_setpwent();
-extern struct passwd* prefix_getpwent();
-extern void prefix_endpwent();
-extern void prefix_setgrent();
-extern struct group* prefix_getgrent();
-extern void prefix_endgrent();
+extern void prefix_setpwent(void);
+extern struct passwd* prefix_getpwent(void);
+extern void prefix_endpwent(void);
+extern void prefix_setgrent(void);
+extern struct group* prefix_getgrent(void);
+extern void prefix_endgrent(void);
 
 /* pwd2spwd.c */
 #ifndef USE_PAM

diff --git a/libmisc/prefix_flag.c b/libmisc/prefix_flag.c
index d4dfbc20ba317d77a20410bf1b7d2160af6f91fb..4eb515476c2a8e2a39935cbcda93ba2a374e76dc 100644 (file)
--- a/libmisc/prefix_flag.c
+++ b/libmisc/prefix_flag.c
@@ -248,7 +248,7 @@ extern struct spwd *prefix_getspnam(const char* name)
        }
 }
 
-extern void prefix_setpwent()
+extern void prefix_setpwent(void)
 {
        if (!passwd_db_file) {
                setpwent();
@@ -261,7 +261,7 @@ extern void prefix_setpwent()
        if (!fp_pwent)
                return;
 }
-extern struct passwd* prefix_getpwent()
+extern struct passwd* prefix_getpwent(void)
 {
        if (!passwd_db_file) {
                return getpwent();
@@ -271,7 +271,7 @@ extern struct passwd* prefix_getpwent()
        }
        return fgetpwent(fp_pwent);
 }
-extern void prefix_endpwent()
+extern void prefix_endpwent(void)
 {
        if (!passwd_db_file) {
                endpwent();
@@ -282,7 +282,7 @@ extern void prefix_endpwent()
        fp_pwent = NULL;
 }
 
-extern void prefix_setgrent()
+extern void prefix_setgrent(void)
 {
        if (!group_db_file) {
                setgrent();
@@ -295,14 +295,14 @@ extern void prefix_setgrent()
        if (!fp_grent)
                return;
 }
-extern struct group* prefix_getgrent()
+extern struct group* prefix_getgrent(void)
 {
        if (!group_db_file) {
                return getgrent();
        }
        return fgetgrent(fp_grent);
 }
-extern void prefix_endgrent()
+extern void prefix_endgrent(void)
 {
        if (!group_db_file) {
                endgrent();