]> git.ipfire.org Git - thirdparty/shadow.git/commitdiff
Use reallocf(3) instead of its pattern
authorAlejandro Colomar <alx@kernel.org>
Sat, 4 Feb 2023 20:25:04 +0000 (21:25 +0100)
committerSerge Hallyn <serge@hallyn.com>
Fri, 24 Feb 2023 02:28:43 +0000 (20:28 -0600)
In addition, don't set local variables just before return.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
lib/sgetgrent.c

index 0138f94b14e95b4b1951e743be01d528d0b57d95..5a368e97ad21222e7994dc4c42d346e4768c6848 100644 (file)
@@ -37,7 +37,6 @@ static char **list (char *s)
        static char **members = NULL;
        static int size = 0;    /* max members + 1 */
        int i;
-       char **rbuf;
 
        i = 0;
        for (;;) {
@@ -45,14 +44,9 @@ static char **list (char *s)
                   member name, or terminating NULL).  */
                if (i >= size) {
                        size = i + 100; /* at least: i + 1 */
-                       rbuf = realloc (members, size * sizeof (char *));
-                       if (!rbuf) {
-                               free (members);
-                               members = NULL;
-                               size = 0;
+                       members = reallocf (members, size * sizeof (char *));
+                       if (!members)
                                return NULL;
-                       }
-                       members = rbuf;
                }
                if (!s || s[0] == '\0')
                        break;