]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:auth: Fix leaks
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 10 Aug 2023 21:56:55 +0000 (09:56 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 14 Aug 2023 04:57:34 +0000 (04:57 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/auth/system_session.c

index 981898bf2f76f5ab784cc60e4a14c162140f173a..dd9a8797a826fac16d91064e7677d117f6f23eb3 100644 (file)
@@ -99,11 +99,13 @@ NTSTATUS auth_system_session_info(TALLOC_CTX *parent_ctx,
 
        session_info->credentials = cli_credentials_init(session_info);
        if (!session_info->credentials) {
+               talloc_free(session_info);
                return NT_STATUS_NO_MEMORY;
        }
 
        ok = cli_credentials_set_conf(session_info->credentials, lp_ctx);
        if (!ok) {
+               talloc_free(session_info);
                return NT_STATUS_INTERNAL_ERROR;
        }
 
@@ -426,11 +428,13 @@ _PUBLIC_ NTSTATUS auth_anonymous_session_info(TALLOC_CTX *parent_ctx,
 
        session_info->credentials = cli_credentials_init(session_info);
        if (!session_info->credentials) {
+               talloc_free(session_info);
                return NT_STATUS_NO_MEMORY;
        }
 
        ok = cli_credentials_set_conf(session_info->credentials, lp_ctx);
        if (!ok) {
+               talloc_free(session_info);
                return NT_STATUS_INTERNAL_ERROR;
        }
        cli_credentials_set_anonymous(session_info->credentials);