]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: ti: omap3pandora: update board check to use DT compatible
authorEthan Nelson-Moore <enelsonmoore@gmail.com>
Sun, 10 May 2026 05:39:37 +0000 (22:39 -0700)
committerMark Brown <broonie@kernel.org>
Sun, 10 May 2026 13:45:39 +0000 (22:45 +0900)
The omap3pandora driver contains a check for the ARM machine ID via the
machine_is_omap3_pandora() macro. The board concerned now supports
only FDT booting, which does not use machine IDs, and therefore the
code should be updated to check the DT compatible property instead. The
legacy board file for this machine was removed in commit 7fcf7e061edd
("ARM: OMAP2+: Remove legacy booting support for Pandora").
The presence of this machine ID check prevents the removal of machine
IDs no longer used by the kernel from arch/arm/tools/mach-types,
because the machine_is_*() macros are generated from mach-types. To
resolve this issue, use of_machine_is_compatible() instead.

Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/ti/omap3pandora.c

index f11b1d8a1306c08f26b294fa7db6185086462dd2..6c9c184cd9d6f6dbfcca7557e95c3b5cae406a3d 100644 (file)
 #include <linux/delay.h>
 #include <linux/regulator/consumer.h>
 #include <linux/module.h>
+#include <linux/of.h>
 
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/soc.h>
 
-#include <asm/mach-types.h>
 #include <linux/platform_data/asoc-ti-mcbsp.h>
 
 #include "omap-mcbsp.h"
@@ -225,7 +225,8 @@ static int __init omap3pandora_soc_init(void)
 {
        int ret;
 
-       if (!machine_is_omap3_pandora())
+       if (!of_machine_is_compatible("openpandora,omap3-pandora-600mhz") &&
+               !of_machine_is_compatible("openpandora,omap3-pandora-1ghz"))
                return -ENODEV;
 
        pr_info("OMAP3 Pandora SoC init\n");