]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
coresight: core: Add provision for panic callbacks
authorLinu Cherian <lcherian@marvell.com>
Wed, 12 Feb 2025 11:49:13 +0000 (17:19 +0530)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Fri, 21 Feb 2025 16:17:13 +0000 (16:17 +0000)
Panic callback handlers allows coresight device drivers to sync
relevant trace data and trace metadata to reserved memory
regions so that they can be retrieved later in the subsequent
boot or in the crashdump kernel.

Signed-off-by: Linu Cherian <lcherian@marvell.com>
Reviewed-by: James Clark <james.clark@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20250212114918.548431-4-lcherian@marvell.com
drivers/hwtracing/coresight/coresight-core.c
include/linux/coresight.h

index 0a9380350fb5252206360077e3dd5e3c7af09acd..ab55e10d4b7983ec00fec3fb5b47bca98a6a5687 100644 (file)
@@ -19,6 +19,7 @@
 #include <linux/property.h>
 #include <linux/delay.h>
 #include <linux/pm_runtime.h>
+#include <linux/panic_notifier.h>
 
 #include "coresight-etm-perf.h"
 #include "coresight-priv.h"
@@ -1453,6 +1454,36 @@ const struct bus_type coresight_bustype = {
        .name   = "coresight",
 };
 
+static int coresight_panic_sync(struct device *dev, void *data)
+{
+       int mode;
+       struct coresight_device *csdev;
+
+       /* Run through panic sync handlers for all enabled devices */
+       csdev = container_of(dev, struct coresight_device, dev);
+       mode = coresight_get_mode(csdev);
+
+       if ((mode == CS_MODE_SYSFS) || (mode == CS_MODE_PERF)) {
+               if (panic_ops(csdev))
+                       panic_ops(csdev)->sync(csdev);
+       }
+
+       return 0;
+}
+
+static int coresight_panic_cb(struct notifier_block *self,
+                              unsigned long v, void *p)
+{
+       bus_for_each_dev(&coresight_bustype, NULL, NULL,
+                                coresight_panic_sync);
+
+       return 0;
+}
+
+static struct notifier_block coresight_notifier = {
+       .notifier_call = coresight_panic_cb,
+};
+
 static int __init coresight_init(void)
 {
        int ret;
@@ -1465,11 +1496,20 @@ static int __init coresight_init(void)
        if (ret)
                goto exit_bus_unregister;
 
+       /* Register function to be called for panic */
+       ret = atomic_notifier_chain_register(&panic_notifier_list,
+                                            &coresight_notifier);
+       if (ret)
+               goto exit_perf;
+
        /* initialise the coresight syscfg API */
        ret = cscfg_init();
        if (!ret)
                return 0;
 
+       atomic_notifier_chain_unregister(&panic_notifier_list,
+                                            &coresight_notifier);
+exit_perf:
        etm_perf_exit();
 exit_bus_unregister:
        bus_unregister(&coresight_bustype);
@@ -1479,6 +1519,8 @@ exit_bus_unregister:
 static void __exit coresight_exit(void)
 {
        cscfg_exit();
+       atomic_notifier_chain_unregister(&panic_notifier_list,
+                                            &coresight_notifier);
        etm_perf_exit();
        bus_unregister(&coresight_bustype);
 }
index 17276965ff1d03787b0e002bbcb7a378e3753995..3eef4e91df3fe8eeab885c8be97be58f37d697ae 100644 (file)
@@ -340,6 +340,7 @@ enum cs_mode {
 #define link_ops(csdev)                csdev->ops->link_ops
 #define helper_ops(csdev)      csdev->ops->helper_ops
 #define ect_ops(csdev)         csdev->ops->ect_ops
+#define panic_ops(csdev)       csdev->ops->panic_ops
 
 /**
  * struct coresight_ops_sink - basic operations for a sink
@@ -409,11 +410,22 @@ struct coresight_ops_helper {
        int (*disable)(struct coresight_device *csdev, void *data);
 };
 
+
+/**
+ * struct coresight_ops_panic - Generic device ops for panic handing
+ *
+ * @sync       : Sync the device register state/trace data
+ */
+struct coresight_ops_panic {
+       int (*sync)(struct coresight_device *csdev);
+};
+
 struct coresight_ops {
        const struct coresight_ops_sink *sink_ops;
        const struct coresight_ops_link *link_ops;
        const struct coresight_ops_source *source_ops;
        const struct coresight_ops_helper *helper_ops;
+       const struct coresight_ops_panic *panic_ops;
 };
 
 static inline u32 csdev_access_relaxed_read32(struct csdev_access *csa,