]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
iplink: double the buffer size also in iplink_get()
authorMichal Kubecek <mkubecek@suse.cz>
Fri, 1 Sep 2017 16:39:16 +0000 (18:39 +0200)
committerStephen Hemminger <stephen@networkplumber.org>
Fri, 1 Sep 2017 21:15:00 +0000 (14:15 -0700)
Commit 72b365e8e0fd ("libnetlink: Double the dump buffer size") increased
the buffer size for "ip link show" command to 32 KB to handle NICs with
large number of VFs. With "dev" filter, a different code path is taken and
iplink_get() still uses only 16 KB buffer.

The size of 32768 is not very future-proof as NICs supporting 120-128 VFs
are already in use so that single RTM_NEWLINK message in the dump can
exceed 30000 bytes. But it's what rtnl_talk() and rtnl_dump_filter_l() use
so let's be consistent. Once this proves insufficient, all three sizes
should be increased.

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
ip/iplink.c

index 790e3a138bb04c1baaf4ecf3664349fa411165cd..72c3479320686b79d694138a24003331fafa0a28 100644 (file)
@@ -1024,7 +1024,7 @@ int iplink_get(unsigned int flags, char *name, __u32 filt_mask)
        };
        struct {
                struct nlmsghdr n;
-               char buf[16384];
+               char buf[32768];
        } answer;
 
        if (name) {