]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[3986] Addresses two small @todos in unrelated test.
authorTomek Mrugalski <tomasz@isc.org>
Tue, 6 Oct 2015 21:56:36 +0000 (23:56 +0200)
committerTomek Mrugalski <tomasz@isc.org>
Tue, 6 Oct 2015 21:56:36 +0000 (23:56 +0200)
src/bin/dhcp4/tests/hooks_unittest.cc

index 9622d4ea151e3ef0d95c7d6efb7e91ad3dbf653c..91c5253bef62283cb77958ae2ad0878d8d9af875 100644 (file)
@@ -1454,15 +1454,13 @@ TEST_F(HooksDhcpv4SrvTest, lease4ReleaseSkip) {
     l = LeaseMgrFactory::instance().getLease4(*client_id_, subnet_->getID());
     EXPECT_TRUE(l);
 
-    // Try to get the lease by hardware address
-    // @todo: Uncomment this once trac2592 is implemented
-    // Lease4Collection leases = LeaseMgrFactory::instance().getLease4(hw->hwaddr_);
-    // EXPECT_EQ(leases.size(), 1);
+    // Try to get the lease by hardware address, should succeed
+    Lease4Collection leases = LeaseMgrFactory::instance().getLease4(*hw);
+    EXPECT_EQ(leases.size(), 1);
 
-    // Try by client-id
-    // @todo: Uncomment this once trac2592 is implemented
-    //Lease4Collection leases = LeaseMgrFactory::instance().getLease4(*client_id_);
-    //EXPECT_EQ(leases.size(), 1);
+    // Try by client-id, should be successful as well.
+    leases = LeaseMgrFactory::instance().getLease4(*client_id_);
+    EXPECT_EQ(leases.size(), 1);
 }
 
 // Checks that decline4 hooks are triggered properly.