]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: tlv320adcx140: fix word length
authorEmil Svendsen <emas@bang-olufsen.dk>
Tue, 13 Jan 2026 10:58:47 +0000 (11:58 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 14 Jan 2026 13:35:32 +0000 (13:35 +0000)
The word length is the physical width of the channel slots. So the
hw_params would misconfigure when format width and physical width
doesn't match. Like S24_LE which has data width of 24 bits but physical
width of 32 bits. So if using asymmetric formats you will get a lot of
noise.

Fixes: 689c7655b50c5 ("ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family")
Signed-off-by: Emil Svendsen <emas@bang-olufsen.dk>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Link: https://patch.msgid.link/20260113-sound-soc-codecs-tvl320adcx140-v4-4-8f7ecec525c8@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tlv320adcx140.c

index 58a6dfa228cc326d18b3c3f126732033749c8e49..fdf4a9add852deb5e879dba5c8a09458fc6e709d 100644 (file)
@@ -725,7 +725,7 @@ static int adcx140_hw_params(struct snd_pcm_substream *substream,
        struct adcx140_priv *adcx140 = snd_soc_component_get_drvdata(component);
        u8 data = 0;
 
-       switch (params_width(params)) {
+       switch (params_physical_width(params)) {
        case 16:
                data = ADCX140_16_BIT_WORD;
                break;
@@ -740,7 +740,7 @@ static int adcx140_hw_params(struct snd_pcm_substream *substream,
                break;
        default:
                dev_err(component->dev, "%s: Unsupported width %d\n",
-                       __func__, params_width(params));
+                       __func__, params_physical_width(params));
                return -EINVAL;
        }