]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
log: prevents use of uninitialized variable
authorPhilippe Antoine <contact@catenacyber.fr>
Thu, 10 Mar 2022 14:26:48 +0000 (15:26 +0100)
committerVictor Julien <vjulien@oisf.net>
Fri, 25 Mar 2022 06:46:15 +0000 (07:46 +0100)
Even if the code seems unreachable for now

src/alert-debuglog.c

index e2d1fb85dddc19c69b4fd1c8b0c230e5d90f41d2..8a20a8b5aca601561ceae81fd53d687d82d6d636 100644 (file)
@@ -42,6 +42,7 @@
 #include "util-unittest.h"
 
 #include "util-debug.h"
+#include "util-validate.h"
 #include "util-buffer.h"
 
 #include "output.h"
@@ -175,7 +176,8 @@ static TmEcode AlertDebugLogger(ThreadVars *tv, const Packet *p, void *thread_da
     if (PKT_IS_IPV4(p)) {
         PrintInet(AF_INET, (const void *)GET_IPV4_SRC_ADDR_PTR(p), srcip, sizeof(srcip));
         PrintInet(AF_INET, (const void *)GET_IPV4_DST_ADDR_PTR(p), dstip, sizeof(dstip));
-    } else if (PKT_IS_IPV6(p)) {
+    } else {
+        DEBUG_VALIDATE_BUG_ON(!(PKT_IS_IPV6(p)));
         PrintInet(AF_INET6, (const void *)GET_IPV6_SRC_ADDR(p), srcip, sizeof(srcip));
         PrintInet(AF_INET6, (const void *)GET_IPV6_DST_ADDR(p), dstip, sizeof(dstip));
     }