]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: imu: inv_icm42600: Avoid configuring if already pm_runtime suspended
authorSean Nyekjaer <sean@geanix.com>
Mon, 1 Sep 2025 07:49:15 +0000 (09:49 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 10 Sep 2025 18:47:05 +0000 (19:47 +0100)
Do as in suspend, skip resume configuration steps if the device is already
pm_runtime suspended. This avoids reconfiguring a device that is already
in the correct low-power state and ensures that pm_runtime handles the
power state transitions properly.

Fixes: 31c24c1e93c3 ("iio: imu: inv_icm42600: add core of new inv_icm42600 driver")
Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Link: https://patch.msgid.link/20250901-icm42pmreg-v3-3-ef1336246960@geanix.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/inv_icm42600/inv_icm42600_core.c

index 41b275ecc7e25ea0b8cdf59be514cdf8a4957ab4..ee780f530dc8612cd25dc2216b153ef4e8c32b7b 100644 (file)
@@ -837,17 +837,15 @@ static int inv_icm42600_suspend(struct device *dev)
        struct device *accel_dev;
        bool wakeup;
        int accel_conf;
-       int ret;
+       int ret = 0;
 
        mutex_lock(&st->lock);
 
        st->suspended.gyro = st->conf.gyro.mode;
        st->suspended.accel = st->conf.accel.mode;
        st->suspended.temp = st->conf.temp_en;
-       if (pm_runtime_suspended(dev)) {
-               ret = 0;
+       if (pm_runtime_suspended(dev))
                goto out_unlock;
-       }
 
        /* disable FIFO data streaming */
        if (st->fifo.on) {
@@ -900,10 +898,13 @@ static int inv_icm42600_resume(struct device *dev)
        struct inv_icm42600_sensor_state *accel_st = iio_priv(st->indio_accel);
        struct device *accel_dev;
        bool wakeup;
-       int ret;
+       int ret = 0;
 
        mutex_lock(&st->lock);
 
+       if (pm_runtime_suspended(dev))
+               goto out_unlock;
+
        /* check wakeup capability */
        accel_dev = &st->indio_accel->dev;
        wakeup = st->apex.on && device_may_wakeup(accel_dev);