]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Revert "gfs2: Fix use of bio_chain"
authorAndreas Gruenbacher <agruenba@redhat.com>
Mon, 12 Jan 2026 10:47:35 +0000 (11:47 +0100)
committerAndreas Gruenbacher <agruenba@redhat.com>
Mon, 12 Jan 2026 13:58:32 +0000 (14:58 +0100)
This reverts commit 8a157e0a0aa5143b5d94201508c0ca1bb8cfb941.

That commit incorrectly assumed that the bio_chain() arguments were
swapped in gfs2.  However, gfs2 intentionally constructs bio chains so
that the first bio's bi_end_io callback is invoked when all bios in the
chain have completed, unlike bio chains where the last bio's callback is
invoked.

Fixes: 8a157e0a0aa5 ("gfs2: Fix use of bio_chain")
Cc: stable@vger.kernel.org
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/lops.c

index 97ebe457c00adfcf289257ed910e95a3a893aa9d..d27a0b1080a97f446832687b46b7d9afa3e77237 100644 (file)
@@ -484,7 +484,7 @@ static struct bio *gfs2_chain_bio(struct bio *prev, unsigned int nr_iovecs)
        new = bio_alloc(prev->bi_bdev, nr_iovecs, prev->bi_opf, GFP_NOIO);
        bio_clone_blkg_association(new, prev);
        new->bi_iter.bi_sector = bio_end_sector(prev);
-       bio_chain(prev, new);
+       bio_chain(new, prev);
        submit_bio(prev);
        return new;
 }