]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuMonitorOpenUnix: Don't overwrite 'ret' needlessly
authorPeter Krempa <pkrempa@redhat.com>
Tue, 2 Aug 2022 12:41:31 +0000 (14:41 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 3 Aug 2022 12:26:56 +0000 (14:26 +0200)
Directly check the return value of 'connect'. Unfortunately we can't
remove it as we have to undo auto-closing of the socket on success.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
src/qemu/qemu_monitor.c

index ad5e121359b2e3c50b2934b59b3c76765eeb4595..0c0b07d4a5b7e058adb5731fb1200612f9b48a9e 100644 (file)
@@ -245,8 +245,7 @@ qemuMonitorOpenUnix(const char *monitor)
         return -1;
     }
 
-    ret = connect(monfd, (struct sockaddr *) &addr, sizeof(addr));
-    if (ret < 0) {
+    if (connect(monfd, (struct sockaddr *) &addr, sizeof(addr)) < 0) {
         virReportSystemError(errno, "%s",
                              _("failed to connect to monitor socket"));
         return -1;