]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: codecs: wsa883x: suppress variant printk
authorJohan Hovold <johan@kernel.org>
Fri, 2 Jan 2026 11:14:13 +0000 (12:14 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 5 Jan 2026 13:14:36 +0000 (13:14 +0000)
Drivers should generally be silent on successful probe.

Demote the codec variant printk to debug level and instead add a warning
in case an unknown variant is ever encountered.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260102111413.9605-5-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wsa883x.c

index 3ffea56aeb0fa3e8d84178f2f0e61ecb6f46f948..468d2b38a22ab853d0d6024891a3395761b854fe 100644 (file)
@@ -1058,22 +1058,23 @@ static int wsa883x_init(struct wsa883x_priv *wsa883x)
 
        switch (variant) {
        case WSA8830:
-               dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8830\n",
-                        version);
+               dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8830\n",
+                       version);
                break;
        case WSA8835:
-               dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835\n",
-                        version);
+               dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835\n",
+                       version);
                break;
        case WSA8832:
-               dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8832\n",
-                        version);
+               dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8832\n",
+                       version);
                break;
        case WSA8835_V2:
-               dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835_V2\n",
-                        version);
+               dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835_V2\n",
+                       version);
                break;
        default:
+               dev_warn(wsa883x->dev, "unknown variant: %d\n", variant);
                break;
        }