]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
btrfs: use variable for end offset in extent_writepage_io()
authorFilipe Manana <fdmanana@suse.com>
Fri, 10 Oct 2025 16:04:03 +0000 (17:04 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 24 Nov 2025 20:59:08 +0000 (21:59 +0100)
Instead of repeating the expression "start + len" multiple times, store it
in a variable and use it where needed.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Anand Jain <asj@kernel.org>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent_io.c

index 3a57aeb3c6228c308f7e486b2f263e224eb9865c..a8f75a4f89850e49850bf16f8438d2c4bd20acff 100644 (file)
@@ -1690,6 +1690,7 @@ static noinline_for_stack int extent_writepage_io(struct btrfs_inode *inode,
        unsigned long range_bitmap = 0;
        bool submitted_io = false;
        int found_error = 0;
+       const u64 end = start + len;
        const u64 folio_start = folio_pos(folio);
        const u64 folio_end = folio_start + folio_size(folio);
        const unsigned int blocks_per_folio = btrfs_blocks_per_folio(fs_info, folio);
@@ -1697,7 +1698,7 @@ static noinline_for_stack int extent_writepage_io(struct btrfs_inode *inode,
        int bit;
        int ret = 0;
 
-       ASSERT(start >= folio_start && start + len <= folio_end);
+       ASSERT(start >= folio_start && end <= folio_end);
 
        ret = btrfs_writepage_cow_fixup(folio);
        if (ret == -EAGAIN) {
@@ -1713,7 +1714,7 @@ static noinline_for_stack int extent_writepage_io(struct btrfs_inode *inode,
                return ret;
        }
 
-       for (cur = start; cur < start + len; cur += fs_info->sectorsize)
+       for (cur = start; cur < end; cur += fs_info->sectorsize)
                set_bit((cur - folio_start) >> fs_info->sectorsize_bits, &range_bitmap);
        bitmap_and(&bio_ctrl->submit_bitmap, &bio_ctrl->submit_bitmap, &range_bitmap,
                   blocks_per_folio);
@@ -1742,7 +1743,7 @@ static noinline_for_stack int extent_writepage_io(struct btrfs_inode *inode,
                        btrfs_put_ordered_extent(ordered);
 
                        btrfs_mark_ordered_io_finished(inode, folio, cur,
-                                                      start + len - cur, true);
+                                                      end - cur, true);
                        /*
                         * This range is beyond i_size, thus we don't need to
                         * bother writing back.
@@ -1751,8 +1752,7 @@ static noinline_for_stack int extent_writepage_io(struct btrfs_inode *inode,
                         * writeback the sectors with subpage dirty bits,
                         * causing writeback without ordered extent.
                         */
-                       btrfs_folio_clear_dirty(fs_info, folio, cur,
-                                               start + len - cur);
+                       btrfs_folio_clear_dirty(fs_info, folio, cur, end - cur);
                        break;
                }
                ret = submit_one_sector(inode, folio, cur, bio_ctrl, i_size);