]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
tests: add a function for checking exclusive flags
authorJán Tomko <jtomko@redhat.com>
Sun, 9 Sep 2018 01:33:57 +0000 (03:33 +0200)
committerJán Tomko <jtomko@redhat.com>
Wed, 12 Sep 2018 19:12:22 +0000 (21:12 +0200)
We can reject some non-sensical combinations with an error
message, once we add flags for them.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
tests/qemuxml2argvtest.c

index d7b50d7ea0d813ed0ab0046c98ad4590b7147694..660330e2523471ff43fe0bb7351545f545c47b7b 100644 (file)
@@ -465,6 +465,18 @@ testCompareXMLToStartupXML(const void *data)
 }
 
 
+static int
+testCheckExclusiveFlags(int flags)
+{
+    virCheckFlags(FLAG_EXPECT_FAILURE |
+                  FLAG_EXPECT_PARSE_ERROR |
+                  FLAG_FIPS |
+                  0, -1);
+
+    return 0;
+}
+
+
 static int
 testCompareXMLToArgv(const void *data)
 {
@@ -507,6 +519,9 @@ testCompareXMLToArgv(const void *data)
     if (virQEMUCapsGet(info->qemuCaps, QEMU_CAPS_ENABLE_FIPS))
         flags |= FLAG_FIPS;
 
+    if (testCheckExclusiveFlags(info->flags) < 0)
+        goto cleanup;
+
     if (qemuTestCapsCacheInsert(driver.qemuCapsCache, info->qemuCaps) < 0)
         goto cleanup;