girparser: Classes are considered sealed when there were no fields found

Fixes https://gitlab.gnome.org/GNOME/vala/issues/1036

diff --git a/vala/valaclass.vala b/vala/valaclass.vala
index 436a6b3cfe3f9d6c9b33ff9e84f38957c980477e..a87bb4240de12e591be8f48b9a28ed44e69a6d67 100644 (file)
--- a/vala/valaclass.vala
+++ b/vala/valaclass.vala
@@ -592,7 +592,7 @@ public class Vala.Class : ObjectTypeSymbol {
                        add_constructor (c);
                }
 
-               if (base_class != null && base_class.is_sealed) {
+               if (!external_package && base_class != null && base_class.is_sealed) {
                        error = true;
                        Report.error (source_reference, "`%s' cannot inherit from sealed class `%s'", get_full_name (), base_class.get_full_name ());
                }

diff --git a/vala/valagirparser.vala b/vala/valagirparser.vala
index 70206da6c9b859c99e6056fa9f261e0ed103472f..d86e19f1676b63661eae4cc24f8e904ec51f3645 100644 (file)
--- a/vala/valagirparser.vala
+++ b/vala/valagirparser.vala
@@ -3137,6 +3137,16 @@ public class Vala.GirParser : CodeVisitor {
                        pop_metadata ();
                }
 
+               // There is no instance field therefore this type might be final/sealed
+               if (first_field && !cl.is_abstract && !(cl.is_opaque || cl.is_sealed)) {
+                       if (!cl.is_compact
+                           && !metadata.has_argument (ArgumentType.ABSTRACT)
+                           && !metadata.has_argument (ArgumentType.COMPACT)
+                           && !metadata.has_argument (ArgumentType.SEALED)) {
+                               cl.is_sealed = true;
+                       }
+               }
+
                pop_node ();
                end_element ("class");
        }