Tunnel edit: Highlight erroring field keys in red

Signed-off-by: Roopesh Chander <roop@roopc.net>

diff --git a/WireGuard/WireGuard/UI/iOS/TunnelEditTableViewController.swift b/WireGuard/WireGuard/UI/iOS/TunnelEditTableViewController.swift
index fac2b37b8a78890d726afbb4fd1b45feedd29cc0..c9f159d01f49464d54b573ca5e6501bffac64464 100644 (file)
--- a/WireGuard/WireGuard/UI/iOS/TunnelEditTableViewController.swift
+++ b/WireGuard/WireGuard/UI/iOS/TunnelEditTableViewController.swift
@@ -72,6 +72,7 @@ class TunnelEditTableViewController: UITableViewController {
         case .error(let errorMessage):
             let erroringConfiguration = (tunnelViewModel.interfaceData.validatedConfiguration == nil) ? "Interface" : "Peer"
             ErrorPresenter.showErrorAlert(title: "Invalid \(erroringConfiguration)", message: errorMessage, from: self)
+            self.tableView.reloadData() // Highlight erroring fields
         case .saved(let tunnelConfiguration):
             if let tunnel = tunnel {
                 // We're modifying an existing tunnel
@@ -201,6 +202,8 @@ extension TunnelEditTableViewController {
                 } else if (field == .addresses || field == .dns) {
                     cell.keyboardType = .numbersAndPunctuation
                 }
+                // Show erroring fields
+                cell.isValueValid = (!interfaceData.fieldsWithError.contains(field))
                 // Bind values to view model
                 cell.value = interfaceData[field]
                 if (field == .dns) { // While editing DNS, you might directly set exclude private IPs
@@ -282,6 +285,8 @@ extension TunnelEditTableViewController {
                 } else if (field == .allowedIPs) {
                     cell.keyboardType = .numbersAndPunctuation
                 }
+                // Show erroring fields
+                cell.isValueValid = (!peerData.fieldsWithError.contains(field))
                 // Bind values to view model
                 cell.value = peerData[field]
                 if (field != .allowedIPs) {
@@ -383,8 +388,8 @@ class TunnelEditTableViewKeyValueCell: CopyableLabelTableViewCell {
         }
     }
     var isValueValid: Bool = true {
-        didSet(value) {
-            if (value) {
+        didSet {
+            if (isValueValid) {
                 keyLabel.textColor = isValueEditable ? UIColor.black : UIColor.gray
             } else {
                 keyLabel.textColor = UIColor.red