]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
be2net: Use correct byte order and format string for TCP seq and ack_seq
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Thu, 17 Jul 2025 19:35:47 +0000 (12:35 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 19 Jul 2025 00:31:16 +0000 (17:31 -0700)
The TCP header fields seq and ack_seq are 32-bit values in network
byte order as (__be32). these fields were earlier printed using
ntohs(), which converts only 16-bit values and produces incorrect
results for 32-bit fields. This patch is changeing the conversion
to ntohl(), ensuring correct interpretation of these sequence numbers.

Notably, the format specifier is updated from %d to %u to reflect the
unsigned nature of these fields.

improves the accuracy of debug log messages for TCP sequence and
acknowledgment numbers during TX timeouts.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250717193552.3648791-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/emulex/benet/be_main.c

index f49400ba97294f577fa408e7607d30a57b33eddb..cb004fd16252730c09e3bb67a0d95a66e27f5958 100644 (file)
@@ -1465,10 +1465,10 @@ static void be_tx_timeout(struct net_device *netdev, unsigned int txqueue)
                                                 ntohs(tcphdr->source));
                                        dev_info(dev, "TCP dest port %d\n",
                                                 ntohs(tcphdr->dest));
-                                       dev_info(dev, "TCP sequence num %d\n",
-                                                ntohs(tcphdr->seq));
-                                       dev_info(dev, "TCP ack_seq %d\n",
-                                                ntohs(tcphdr->ack_seq));
+                                       dev_info(dev, "TCP sequence num %u\n",
+                                                ntohl(tcphdr->seq));
+                                       dev_info(dev, "TCP ack_seq %u\n",
+                                                ntohl(tcphdr->ack_seq));
                                } else if (ip_hdr(skb)->protocol ==
                                           IPPROTO_UDP) {
                                        udphdr = udp_hdr(skb);