]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/plane: Fix IS_ERR() vs NULL bug drm_plane_create_color_pipeline_property()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 5 Dec 2025 11:09:25 +0000 (14:09 +0300)
committerSimon Ser <contact@emersion.fr>
Thu, 11 Dec 2025 16:39:15 +0000 (17:39 +0100)
The drm_property_create_enum() function returns NULL on error, it never
returns error pointers.  Fix the error checking to match.

Fixes: 2afc3184f3b3 ("drm/plane: Add COLOR PIPELINE property")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Simon Ser <contact@emersion.fr>
Link: https://patch.msgid.link/aTK9ZR0sMgqSACow@stanley.mountain
drivers/gpu/drm/drm_plane.c

index f6cfa8ac090c7bc49c7f276993bba7e9800da140..b87f5f30d36bac8b78ca9d1b4a1a43a6513eacb5 100644 (file)
@@ -1867,9 +1867,9 @@ int drm_plane_create_color_pipeline_property(struct drm_plane *plane,
        prop = drm_property_create_enum(plane->dev, DRM_MODE_PROP_ATOMIC,
                                        "COLOR_PIPELINE",
                                        all_pipelines, len);
-       if (IS_ERR(prop)) {
+       if (!prop) {
                kfree(all_pipelines);
-               return PTR_ERR(prop);
+               return -ENOMEM;
        }
 
        drm_object_attach_property(&plane->base, prop, 0);