net/rds: Give each connection path its own workqueue

RDS was written to require ordered workqueues for "cp->cp_wq":
Work is executed in the order scheduled, one item at a time.

If these workqueues are shared across connections,
then work executed on behalf of one connection blocks work
scheduled for a different and unrelated connection.

Luckily we don't need to share these workqueues.
While it obviously makes sense to limit the number of
workers (processes) that ought to be allocated on a system,
a workqueue that doesn't have a rescue worker attached,
has a tiny footprint compared to the connection as a whole:
A workqueue costs ~900 bytes, including the workqueue_struct,
pool_workqueue, workqueue_attrs, wq_node_nr_active and the
node_nr_active flex array.  Each connection can have up to 8
(RDS_MPATH_WORKERS) paths for a worst case of ~7 KBytes per
connection.  While an RDS/IB connection totals only ~5 MBytes.

So we're getting a signficant performance gain
(90% of connections fail over under 3 seconds vs. 40%)
for a less than 0.02% overhead.

RDS doesn't even benefit from the additional rescue workers:
of all the reasons that RDS blocks workers, allocation under
memory pressue is the least of our concerns. And even if RDS
was stalling due to the memory-reclaim process, the work
executed by the rescue workers are highly unlikely to free up
any memory. If anything, they might try to allocate even more.

By giving each connection path its own workqueues, we allow
RDS to better utilize the unbound workers that the system
has available.

Signed-off-by: Somasundaram Krishnasamy <somasundaram.krishnasamy@oracle.com>
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Link: https://patch.msgid.link/20260109224843.128076-3-achender@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/net/rds/connection.c b/net/rds/connection.c
index dc7323707f450a4e2f34ecace9caa5fe6f98ca61..e920c685e4f29bd5d2298a82a5eb4f80b537d512 100644 (file)
--- a/net/rds/connection.c
+++ b/net/rds/connection.c
@@ -169,6 +169,7 @@ static struct rds_connection *__rds_conn_create(struct net *net,
        struct rds_connection *conn, *parent = NULL;
        struct hlist_head *head = rds_conn_bucket(laddr, faddr);
        struct rds_transport *loop_trans;
+       struct rds_conn_path *free_cp = NULL;
        unsigned long flags;
        int ret, i;
        int npaths = (trans->t_mp_capable ? RDS_MPATH_WORKERS : 1);
@@ -269,7 +270,11 @@ static struct rds_connection *__rds_conn_create(struct net *net,
                __rds_conn_path_init(conn, &conn->c_path[i],
                                     is_outgoing);
                conn->c_path[i].cp_index = i;
-               conn->c_path[i].cp_wq = rds_wq;
+               conn->c_path[i].cp_wq =
+                       alloc_ordered_workqueue("krds_cp_wq#%lu/%d", 0,
+                                               rds_conn_count, i);
+               if (!conn->c_path[i].cp_wq)
+                       conn->c_path[i].cp_wq = rds_wq;
        }
        rcu_read_lock();
        if (rds_destroy_pending(conn))
@@ -278,7 +283,7 @@ static struct rds_connection *__rds_conn_create(struct net *net,
                ret = trans->conn_alloc(conn, GFP_ATOMIC);
        if (ret) {
                rcu_read_unlock();
-               kfree(conn->c_path);
+               free_cp = conn->c_path;
                kmem_cache_free(rds_conn_slab, conn);
                conn = ERR_PTR(ret);
                goto out;
@@ -301,7 +306,7 @@ static struct rds_connection *__rds_conn_create(struct net *net,
                /* Creating passive conn */
                if (parent->c_passive) {
                        trans->conn_free(conn->c_path[0].cp_transport_data);
-                       kfree(conn->c_path);
+                       free_cp = conn->c_path;
                        kmem_cache_free(rds_conn_slab, conn);
                        conn = parent->c_passive;
                } else {
@@ -328,7 +333,7 @@ static struct rds_connection *__rds_conn_create(struct net *net,
                                if (cp->cp_transport_data)
                                        trans->conn_free(cp->cp_transport_data);
                        }
-                       kfree(conn->c_path);
+                       free_cp = conn->c_path;
                        kmem_cache_free(rds_conn_slab, conn);
                        conn = found;
                } else {
@@ -343,6 +348,13 @@ static struct rds_connection *__rds_conn_create(struct net *net,
        rcu_read_unlock();
 
 out:
+       if (free_cp) {
+               for (i = 0; i < npaths; i++)
+                       if (free_cp[i].cp_wq != rds_wq)
+                               destroy_workqueue(free_cp[i].cp_wq);
+               kfree(free_cp);
+       }
+
        return conn;
 }
 
@@ -470,6 +482,11 @@ static void rds_conn_path_destroy(struct rds_conn_path *cp)
        WARN_ON(delayed_work_pending(&cp->cp_conn_w));
        WARN_ON(work_pending(&cp->cp_down_w));
 
+       if (cp->cp_wq != rds_wq) {
+               destroy_workqueue(cp->cp_wq);
+               cp->cp_wq = NULL;
+       }
+
        cp->cp_conn->c_trans->conn_free(cp->cp_transport_data);
 }