arm64/sme: Support disabling streaming mode via ptrace on SME only systems

Currently it is not possible to disable streaming mode via ptrace on SME
only systems, the interface for doing this is to write via NT_ARM_SVE but
such writes will be rejected on a system without SVE support. Enable this
functionality by allowing userspace to write SVE_PT_REGS_FPSIMD format data
via NT_ARM_SVE with the vector length set to 0 on SME only systems. Such
writes currently error since we require that a vector length is specified
which should minimise the risk that existing software is relying on current
behaviour.

Reads are not supported since I am not aware of any use case for this and
there is some risk that an existing userspace application may be confused if
it reads NT_ARM_SVE on a system without SVE. Existing kernels will return
FPSIMD formatted register state from NT_ARM_SVE if full SVE state is not
stored, for example if the task has not used SVE. Returning a vector length
of 0 would create a risk that software would try to do things like allocate
space for register state with zero sizes, while returning a vector length of
128 bits would look like SVE is supported. It seems safer to just not make
the changes to add read support.

It remains possible for userspace to detect a SME only system via the ptrace
interface only since reads of NT_ARM_SSVE and NT_ARM_ZA will succeed while
reads of NT_ARM_SVE will fail. Read/write access to the FPSIMD registers in
non-streaming mode is available via REGSET_FPR.

sve_set_common() already avoids allocating SVE storage when doing a FPSIMD
formatted write and allocating SME storage when doing a NT_ARM_SVE write so
we change the function to validate the new case and skip setting a vector
length for it.

The aim is to make a minimally invasive change, no operation that would
previously have succeeded will be affected, and we use a previously
defined interface in new circumstances rather than define completely new
ABI.

Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: David Spickett <david.spickett@linaro.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

diff --git a/Documentation/arch/arm64/sve.rst b/Documentation/arch/arm64/sve.rst
index 28152492c29cbc7a81165a367e87d4aa327690f4..a61c9d0efe4d811c997a6d644b148c6b73291081 100644 (file)
--- a/Documentation/arch/arm64/sve.rst
+++ b/Documentation/arch/arm64/sve.rst
@@ -402,6 +402,11 @@ The regset data starts with struct user_sve_header, containing:
   streaming mode and any SETREGSET of NT_ARM_SSVE will enter streaming mode
   if the target was not in streaming mode.
 
+* On systems that do not support SVE it is permitted to use SETREGSET to
+  write SVE_PT_REGS_FPSIMD formatted data via NT_ARM_SVE, in this case the
+  vector length should be specified as 0. This allows streaming mode to be
+  disabled on systems with SME but not SVE.
+
 * If any register data is provided along with SVE_PT_VL_ONEXEC then the
   registers data will be interpreted with the current vector length, not
   the vector length configured for use on exec.

diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
index 4b001121c72dbe44700766c7b45249a03559ae9d..b9bdd83fbbca0f3ba6b6b0d1458fcfedb8a9a998 100644 (file)
--- a/arch/arm64/kernel/ptrace.c
+++ b/arch/arm64/kernel/ptrace.c
@@ -912,13 +912,39 @@ static int sve_set_common(struct task_struct *target,
                return -EINVAL;
 
        /*
-        * Apart from SVE_PT_REGS_MASK, all SVE_PT_* flags are consumed by
-        * vec_set_vector_length(), which will also validate them for us:
+        * On systems without SVE we accept FPSIMD format writes with
+        * a VL of 0 to allow exiting streaming mode, otherwise a VL
+        * is required.
         */
-       ret = vec_set_vector_length(target, type, header.vl,
-               ((unsigned long)header.flags & ~SVE_PT_REGS_MASK) << 16);
-       if (ret)
-               return ret;
+       if (header.vl) {
+               /*
+                * If the system does not support SVE we can't
+                * configure a SVE VL.
+                */
+               if (!system_supports_sve() && type == ARM64_VEC_SVE)
+                       return -EINVAL;
+
+               /*
+                * Apart from SVE_PT_REGS_MASK, all SVE_PT_* flags are
+                * consumed by vec_set_vector_length(), which will
+                * also validate them for us:
+                */
+               ret = vec_set_vector_length(target, type, header.vl,
+                                           ((unsigned long)header.flags & ~SVE_PT_REGS_MASK) << 16);
+               if (ret)
+                       return ret;
+       } else {
+               /* If the system supports SVE we require a VL. */
+               if (system_supports_sve())
+                       return -EINVAL;
+
+               /*
+                * Only FPSIMD formatted data with no flags set is
+                * supported.
+                */
+               if (header.flags != SVE_PT_REGS_FPSIMD)
+                       return -EINVAL;
+       }
 
        /* Allocate SME storage if necessary, preserving any existing ZA/ZT state */
        if (type == ARM64_VEC_SME) {
@@ -1016,7 +1042,7 @@ static int sve_set(struct task_struct *target,
                   unsigned int pos, unsigned int count,
                   const void *kbuf, const void __user *ubuf)
 {
-       if (!system_supports_sve())
+       if (!system_supports_sve() && !system_supports_sme())
                return -EINVAL;
 
        return sve_set_common(target, regset, pos, count, kbuf, ubuf,