]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: caam - Replace snprintf with strscpy in caam_hash_alloc
authorThorsten Blum <thorsten.blum@linux.dev>
Mon, 2 Feb 2026 23:01:17 +0000 (00:01 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 28 Feb 2026 03:53:58 +0000 (12:53 +0900)
Replace snprintf("%s", ...) with the faster and more direct strscpy().

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/caam/caamalg_qi2.c
drivers/crypto/caam/caamhash.c

index 167372936ca7003dd6d38139a3ca7d80824a00bc..553994228a17b338589a5c8a7f484bdc02e41b31 100644 (file)
@@ -19,6 +19,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/fsl/mc.h>
 #include <linux/kernel.h>
+#include <linux/string.h>
 #include <linux/string_choices.h>
 #include <soc/fsl/dpaa2-io.h>
 #include <soc/fsl/dpaa2-fd.h>
@@ -4644,16 +4645,12 @@ static struct caam_hash_alg *caam_hash_alloc(struct device *dev,
        alg = &halg->halg.base;
 
        if (keyed) {
-               snprintf(alg->cra_name, CRYPTO_MAX_ALG_NAME, "%s",
-                        template->hmac_name);
-               snprintf(alg->cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s",
-                        template->hmac_driver_name);
+               strscpy(alg->cra_name, template->hmac_name);
+               strscpy(alg->cra_driver_name, template->hmac_driver_name);
                t_alg->is_hmac = true;
        } else {
-               snprintf(alg->cra_name, CRYPTO_MAX_ALG_NAME, "%s",
-                        template->name);
-               snprintf(alg->cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s",
-                        template->driver_name);
+               strscpy(alg->cra_name, template->name);
+               strscpy(alg->cra_driver_name, template->driver_name);
                t_alg->ahash_alg.setkey = NULL;
                t_alg->is_hmac = false;
        }
index 628c43a7efc41fe5b5b091daaab4d77f691f9865..e0a23c55c10e0fa992cdb212bc0cce8dfc7e2f0c 100644 (file)
@@ -1913,16 +1913,12 @@ caam_hash_alloc(struct caam_hash_template *template,
        alg = &halg->halg.base;
 
        if (keyed) {
-               snprintf(alg->cra_name, CRYPTO_MAX_ALG_NAME, "%s",
-                        template->hmac_name);
-               snprintf(alg->cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s",
-                        template->hmac_driver_name);
+               strscpy(alg->cra_name, template->hmac_name);
+               strscpy(alg->cra_driver_name, template->hmac_driver_name);
                t_alg->is_hmac = true;
        } else {
-               snprintf(alg->cra_name, CRYPTO_MAX_ALG_NAME, "%s",
-                        template->name);
-               snprintf(alg->cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s",
-                        template->driver_name);
+               strscpy(alg->cra_name, template->name);
+               strscpy(alg->cra_driver_name, template->driver_name);
                halg->setkey = NULL;
                t_alg->is_hmac = false;
        }