FS-7294: Enable -Werror when building with clang compiler

diff --git a/libs/sofia-sip/libsofia-sip-ua/nua/nua_client.c b/libs/sofia-sip/libsofia-sip-ua/nua/nua_client.c
index 0e8c0dd64f8f4e280bd5433ef3f594d2576831f1..e15d6787de5cfd5f4e5497cc54f2101a6407cb55 100644 (file)
--- a/libs/sofia-sip/libsofia-sip-ua/nua/nua_client.c
+++ b/libs/sofia-sip/libsofia-sip-ua/nua/nua_client.c
@@ -176,7 +176,7 @@ int nua_client_create(nua_handle_t *nh,
 
       if (tags) {
        nua_move_signal(cr->cr_signal, nh->nh_nua->nua_signal);
-       if (cr->cr_signal) {
+       if (cr->cr_signal[0]) {
          /* Steal reference from signal */
          cr->cr_owner = e->e_nh, e->e_nh = NULL;
          cr->cr_tags = tags;

diff --git a/libs/sofia-sip/libsofia-sip-ua/nua/nua_stack.c b/libs/sofia-sip/libsofia-sip-ua/nua/nua_stack.c
index 85f1647d3e7ef978beed72c74e4545811a44cefd..7364d4b255587c369f36c904ce10a0657faef075 100644 (file)
--- a/libs/sofia-sip/libsofia-sip-ua/nua/nua_stack.c
+++ b/libs/sofia-sip/libsofia-sip-ua/nua/nua_stack.c
@@ -877,7 +877,7 @@ void nua_stack_shutdown(nua_t *nua)
   if (status >= 200) {
     for (nh = nua->nua_handles; nh; nh = nh_next) {
       nh_next = nh->nh_next;
-      while (nh->nh_ds && nh->nh_ds->ds_usage) {
+      while (nh->nh_ds->ds_usage) {
        nua_dialog_usage_remove(nh, nh->nh_ds, nh->nh_ds->ds_usage, NULL, NULL);
       }
     }
@@ -1096,7 +1096,7 @@ sip_replaces_t *nua_stack_handle_make_replaces(nua_handle_t *nh,
                                               su_home_t *home,
                                               int early_only)
 {
-  if (nh && nh->nh_ds && nh->nh_ds->ds_leg)
+  if (nh && nh->nh_ds->ds_leg)
     return nta_leg_make_replaces(nh->nh_ds->ds_leg, home, early_only);
   else
     return NULL;