]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clk: at91: peripheral: fix return value
authorBrian Masney <bmasney@redhat.com>
Mon, 11 Aug 2025 15:17:53 +0000 (11:17 -0400)
committerBrian Masney <bmasney@redhat.com>
Mon, 8 Sep 2025 13:41:25 +0000 (09:41 -0400)
determine_rate() is expected to return an error code, or 0 on success.
clk_sam9x5_peripheral_determine_rate() has a branch that returns the
parent rate on a certain case. This is the behavior of round_rate(),
so let's go ahead and fix this by setting req->rate.

Fixes: b4c115c76184f ("clk: at91: clk-peripheral: add support for changeable parent rate")
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Brian Masney <bmasney@redhat.com>
drivers/clk/at91/clk-peripheral.c

index c173a44c800aa8cc6970c266995f4a60b0a38554..629f050a855aaebfd1a03ff87c2b016cd2284a5a 100644 (file)
@@ -279,8 +279,11 @@ static int clk_sam9x5_peripheral_determine_rate(struct clk_hw *hw,
        long best_diff = LONG_MIN;
        u32 shift;
 
-       if (periph->id < PERIPHERAL_ID_MIN || !periph->range.max)
-               return parent_rate;
+       if (periph->id < PERIPHERAL_ID_MIN || !periph->range.max) {
+               req->rate = parent_rate;
+
+               return 0;
+       }
 
        /* Fist step: check the available dividers. */
        for (shift = 0; shift <= PERIPHERAL_MAX_SHIFT; shift++) {