media: i2c: ov9282: add output enable register definitions

Add #define's for the output enable registers (0x3004, 0x3005, 0x3006),
also known as SC_CTRL_04, SC_CTRL_05, SC_CTRL_04. Use those register
definitions instead of the raw values in the `common_regs` struct.

All values are based on the OV9281 datasheet v1.53 (january 2019).

Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Richard Leitner <richard.leitner@linux.dev>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
index 3e24d88f603c1432865b4d880670e4b67f1b5cec..d7448728cdd1007bd25ba301e9b5ade3a853e0e8 100644 (file)
--- a/drivers/media/i2c/ov9282.c
+++ b/drivers/media/i2c/ov9282.c
@@ -37,6 +37,29 @@
 #define OV9282_REG_ID          0x300a
 #define OV9282_ID              0x9281
 
+/* Output enable registers */
+#define OV9282_REG_OUTPUT_ENABLE4      0x3004
+#define OV9282_OUTPUT_ENABLE4_GPIO2    BIT(1)
+#define OV9282_OUTPUT_ENABLE4_D9       BIT(0)
+
+#define OV9282_REG_OUTPUT_ENABLE5      0x3005
+#define OV9282_OUTPUT_ENABLE5_D8       BIT(7)
+#define OV9282_OUTPUT_ENABLE5_D7       BIT(6)
+#define OV9282_OUTPUT_ENABLE5_D6       BIT(5)
+#define OV9282_OUTPUT_ENABLE5_D5       BIT(4)
+#define OV9282_OUTPUT_ENABLE5_D4       BIT(3)
+#define OV9282_OUTPUT_ENABLE5_D3       BIT(2)
+#define OV9282_OUTPUT_ENABLE5_D2       BIT(1)
+#define OV9282_OUTPUT_ENABLE5_D1       BIT(0)
+
+#define OV9282_REG_OUTPUT_ENABLE6      0x3006
+#define OV9282_OUTPUT_ENABLE6_D0       BIT(7)
+#define OV9282_OUTPUT_ENABLE6_PCLK     BIT(6)
+#define OV9282_OUTPUT_ENABLE6_HREF     BIT(5)
+#define OV9282_OUTPUT_ENABLE6_STROBE   BIT(3)
+#define OV9282_OUTPUT_ENABLE6_ILPWM    BIT(2)
+#define OV9282_OUTPUT_ENABLE6_VSYNC    BIT(1)
+
 /* Exposure control */
 #define OV9282_REG_EXPOSURE    0x3500
 #define OV9282_EXPOSURE_MIN    1
@@ -213,9 +236,9 @@ static const struct ov9282_reg common_regs[] = {
        {0x0302, 0x32},
        {0x030e, 0x02},
        {0x3001, 0x00},
-       {0x3004, 0x00},
-       {0x3005, 0x00},
-       {0x3006, 0x04},
+       {OV9282_REG_OUTPUT_ENABLE4, 0x00},
+       {OV9282_REG_OUTPUT_ENABLE5, 0x00},
+       {OV9282_REG_OUTPUT_ENABLE6, OV9282_OUTPUT_ENABLE6_ILPWM},
        {0x3011, 0x0a},
        {0x3013, 0x18},
        {0x301c, 0xf0},