]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tools/nolibc/select: avoid libgcc 64-bit multiplications
authorThomas Weißschuh <linux@weissschuh.net>
Sat, 20 Dec 2025 13:55:51 +0000 (14:55 +0100)
committerThomas Weißschuh <linux@weissschuh.net>
Sun, 4 Jan 2026 09:29:02 +0000 (10:29 +0100)
timeval::tv_usec is going to be 64-bit wide even on 32-bit
architectures. As not all architectures support 64-bit multiplications
instructions, calls to libgcc (__multi3()) may be emitted by the
compiler which are not provided by nolibc.

As tv_usec and tv_nsec are guaranteed to always fit into an uint32_t,
perform a 32-bit multiplication instead.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Acked-by: Willy Tarreau <w@1wt.eu>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20251220-nolibc-uapi-types-v3-7-c662992f75d7@weissschuh.net
tools/include/nolibc/sys/select.h

index f8870ad496879e192066a8876e3865be4b35310b..80cb3755ba1884cc262e0c17da1926f36603040b 100644 (file)
@@ -68,7 +68,7 @@ int sys_select(int nfds, fd_set *rfds, fd_set *wfds, fd_set *efds, struct timeva
 
        if (timeout) {
                t.tv_sec  = timeout->tv_sec;
-               t.tv_nsec = timeout->tv_usec * 1000;
+               t.tv_nsec = (uint32_t)timeout->tv_usec * 1000;
        }
        return my_syscall6(__NR_pselect6_time64, nfds, rfds, wfds, efds, timeout ? &t : NULL, NULL);
 #else
@@ -76,7 +76,7 @@ int sys_select(int nfds, fd_set *rfds, fd_set *wfds, fd_set *efds, struct timeva
 
        if (timeout) {
                t.tv_sec  = timeout->tv_sec;
-               t.tv_nsec = timeout->tv_usec * 1000;
+               t.tv_nsec = (uint32_t)timeout->tv_usec * 1000;
        }
        return my_syscall6(__NR_pselect6, nfds, rfds, wfds, efds, timeout ? &t : NULL, NULL);
 #endif