]> git.ipfire.org Git - thirdparty/psycopg.git/commitdiff
Define connection.close as asynchronous
authorDaniele Varrazzo <daniele.varrazzo@gmail.com>
Tue, 14 Apr 2020 05:34:02 +0000 (17:34 +1200)
committerDaniele Varrazzo <daniele.varrazzo@gmail.com>
Tue, 14 Apr 2020 08:26:13 +0000 (20:26 +1200)
psycopg3/connection.py

index 769afc9101780a97a37ef1a58be195ae7d573169..bcf606450a6fb6ba0257348331c91c63e880608f 100644 (file)
@@ -57,9 +57,6 @@ class BaseConnection:
         # name of the postgres encoding (in bytes)
         self._pgenc = b""
 
-    def close(self) -> None:
-        self.pgconn.finish()
-
     @property
     def closed(self) -> bool:
         return self.status == self.ConnStatus.BAD
@@ -136,6 +133,9 @@ class Connection(BaseConnection):
         pgconn = cls.wait(gen)
         return cls(pgconn)
 
+    def close(self) -> None:
+        self.pgconn.finish()
+
     def cursor(
         self, name: Optional[str] = None, binary: bool = False
     ) -> cursor.Cursor:
@@ -194,12 +194,15 @@ class AsyncConnection(BaseConnection):
         self.cursor_factory = cursor.AsyncCursor
 
     @classmethod
-    async def connect(cls, conninfo: str, **kwargs: Any) -> "AsyncConnection":
+    async def connect(cls, conninfo: str = "", **kwargs: Any) -> "AsyncConnection":
         conninfo = make_conninfo(conninfo, **kwargs)
         gen = generators.connect(conninfo)
         pgconn = await cls.wait(gen)
         return cls(pgconn)
 
+    async def close(self) -> None:
+        self.pgconn.finish()
+
     def cursor(
         self, name: Optional[str] = None, binary: bool = False
     ) -> cursor.AsyncCursor: