]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
nouveau/gsp: cleanup IS_ERR_OR_NULL in rpc_rd
authorHongling Zeng <zenghongling@kylinos.cn>
Thu, 28 May 2026 06:24:48 +0000 (14:24 +0800)
committerLyude Paul <lyude@redhat.com>
Thu, 28 May 2026 16:49:57 +0000 (12:49 -0400)
The underlying nvkm_gsp_rpc_get() function returns error pointers,
so checking for NULL with IS_ERR_OR_NULL() is redundant. Use IS_ERR()
instead.

This affects nvkm_gsp_rpc_rd().

Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patch.msgid.link/20260528062451.54107-3-zenghongling@kylinos.cn
Reviewed-by: Lyude Paul <lyude@redhat.com>
drivers/gpu/drm/nouveau/include/nvkm/subdev/gsp.h

index ab2bd88eebce58df705441669d154b9daf959ede..d771134fa41075c90058ae4079a386b611be75f8 100644 (file)
@@ -293,7 +293,7 @@ nvkm_gsp_rpc_rd(struct nvkm_gsp *gsp, u32 fn, u32 argc)
 {
        void *argv = nvkm_gsp_rpc_get(gsp, fn, argc);
 
-       if (IS_ERR_OR_NULL(argv))
+       if (IS_ERR(argv))
                return argv;
 
        return nvkm_gsp_rpc_push(gsp, argv, NVKM_GSP_RPC_REPLY_RECV, argc);