iomap: don't make REQ_POLLED imply REQ_NOWAIT

As described in commit 2bc057692599 ("block: don't make REQ_POLLED imply
REQ_NOWAIT"), which fixed the same issue for the block device node, there
are valid cases to poll for I/O completion without REQ_NOWAIT.

Additionally, sing REQ_NOWAIT for file system writes is currently not
supported as file systems writes are not idempotent and would need a
retry of just the bio and not the entire operation to be fully supported.

Switch iomap to set REQ_POLLED and remove the now unused bio_set_polled
helper.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://patch.msgid.link/20260518062917.506483-1-hch@lst.de
Signed-off-by: Christian Brauner <brauner@kernel.org>

diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index a4459c5abb07827296f96faf6cadd5d663ac37ed..3df100fe0bf6c68d378bbc3f73ad4269f8e8a8d4 100644 (file)
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -69,7 +69,7 @@ static void iomap_dio_submit_bio(const struct iomap_iter *iter,
 
        /* Sync dio can't be polled reliably */
        if ((iocb->ki_flags & IOCB_HIPRI) && !is_sync_kiocb(iocb)) {
-               bio_set_polled(bio, iocb);
+               bio->bi_opf |= REQ_POLLED;
                WRITE_ONCE(iocb->private, bio);
        }
 

diff --git a/include/linux/bio.h b/include/linux/bio.h
index 97d747320b35bc34197d026a53b611bf0c170530..fbccb2f264b0133ebc43da8280db7cb2c09c016b 100644 (file)
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -702,20 +702,6 @@ static inline bool bioset_initialized(struct bio_set *bs)
        return bs->bio_slab != NULL;
 }
 
-/*
- * Mark a bio as polled. Note that for async polled IO, the caller must
- * expect -EWOULDBLOCK if we cannot allocate a request (or other resources).
- * We cannot block waiting for requests on polled IO, as those completions
- * must be found by the caller. This is different than IRQ driven IO, where
- * it's safe to wait for IO to complete.
- */
-static inline void bio_set_polled(struct bio *bio, struct kiocb *kiocb)
-{
-       bio->bi_opf |= REQ_POLLED;
-       if (kiocb->ki_flags & IOCB_NOWAIT)
-               bio->bi_opf |= REQ_NOWAIT;
-}
-
 static inline void bio_clear_polled(struct bio *bio)
 {
        bio->bi_opf &= ~REQ_POLLED;