]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
validate: improve verbose messages
authorVladimír Čunát <vladimir.cunat@nic.cz>
Wed, 20 Sep 2017 08:45:39 +0000 (10:45 +0200)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Wed, 20 Sep 2017 08:45:39 +0000 (10:45 +0200)
Next time it will be directly visible what record fails to validate,
which was the most time-expensive part when creating the parent commit.

lib/layer/validate.c

index b35e270872ac110804266023eaa50ff97eafadf7..8b188e0e701d4409404c07827fcbbcd488465a9a 100644 (file)
@@ -444,7 +444,6 @@ static int rrsig_not_found(kr_layer_t *ctx, const knot_rrset_t *rr)
        struct kr_request *req = ctx->req;
        struct kr_query *qry = req->current_query;
 
-       VERBOSE_MSG(qry, ">< no valid RRSIGs found\n");
        struct kr_zonecut *cut = &qry->zone_cut;
        const knot_dname_t *cut_name_start = qry->zone_cut.name;
        bool use_cut = true;
@@ -537,6 +536,11 @@ static int check_validation_result(kr_layer_t *ctx, ranked_rr_array_t *arr)
                VERBOSE_MSG(qry, ">< cut changed (new signer), needs revalidation\n");
                ret = KR_STATE_YIELD;
        } else if (kr_rank_test(invalid_entry->rank, KR_RANK_MISSING)) {
+               WITH_VERBOSE {
+                       VERBOSE_MSG(qry, ">< no valid RRSIGs found for ");
+                       kr_rrtype_print(invalid_entry->rr->type, "", " ");
+                       kr_dname_print(invalid_entry->rr->owner, "", "\n");
+               }
                ret = rrsig_not_found(ctx, rr);
        } else if (!kr_rank_test(invalid_entry->rank, KR_RANK_SECURE)) {
                qry->flags.DNSSEC_BOGUS = true;