]> git.ipfire.org Git - thirdparty/dbus.git/commitdiff
sysdeps: Return an error for _dbus_command_for_pid on Windows
authorSimon McVittie <smcv@collabora.com>
Thu, 25 Oct 2018 15:47:18 +0000 (16:47 +0100)
committerSimon McVittie <smcv@collabora.com>
Wed, 31 Oct 2018 16:56:36 +0000 (16:56 +0000)
If a function returns boolean for success/error, and returns a
DBusError, then it should set the DBusError if and only if it
returns FALSE.

Signed-off-by: Simon McVittie <smcv@collabora.com>
dbus/dbus-sysdeps-util-win.c

index 5aad2a86a318c22537b1c24f6bf77f600db248c2..fc35690804d93b47a8f256e4dfc1c3211d39127e 100644 (file)
@@ -1399,7 +1399,8 @@ _dbus_command_for_pid (unsigned long  pid,
                        int            max_len,
                        DBusError     *error)
 {
-  // FIXME
+  dbus_set_error (error, DBUS_ERROR_NOT_SUPPORTED,
+                  "_dbus_command_for_pid() not implemented on Windows");
   return FALSE;
 }