]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
dmaengine: dw-axi-dmac: Remove unnecessary return statement from void function
authorKhairul Anuar Romli <karom.9560@gmail.com>
Mon, 2 Feb 2026 06:02:19 +0000 (14:02 +0800)
committerVinod Koul <vkoul@kernel.org>
Thu, 26 Feb 2026 15:30:00 +0000 (21:00 +0530)
checkpatch.pl --strict reports a WARNING in dw-axi-dmac-platform.c:

  WARNING: void function return statements are not generally useful
  FILE: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c

According to Linux kernel coding style [Documentation/process/
coding-style.rst], explicit "return;" statements at the end of void
functions are redundant and should be omitted. The function will
automatically return upon reaching the closing brace, so the extra
statement adds unnecessary clutter without functional benefit.

This patch removes the superfluous "return;" statement in
dw_axi_dma_set_hw_channel() to comply with kernel coding standards and
eliminate the checkpatch warning.

Fixes: 32286e279385 ("dmaengine: dw-axi-dmac: Remove free slot check algorithm in dw_axi_dma_set_hw_channel")
Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com>
Link: https://patch.msgid.link/20260202060224.12616-4-karom.9560@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c

index 1e536cb979c4040bd66df783ffbdd88de17dfb1b..c90a83a3bd2ffacaefefec5e745bcbd12e92c8b5 100644 (file)
@@ -593,8 +593,6 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set)
                        (chan->id * DMA_APB_HS_SEL_BIT_SIZE));
        reg_value |= (val << (chan->id * DMA_APB_HS_SEL_BIT_SIZE));
        lo_hi_writeq(reg_value, chip->apb_regs + DMAC_APB_HW_HS_SEL_0);
-
-       return;
 }
 
 /*