]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ARM: dts: NSP: MX6X: correct LED function types
authorMatthew Hagan <mnhagan88@gmail.com>
Wed, 23 Feb 2022 23:50:40 +0000 (23:50 +0000)
committerFlorian Fainelli <f.fainelli@gmail.com>
Fri, 25 Feb 2022 00:47:25 +0000 (16:47 -0800)
Currently, the amber LED will remain always on. This is due to a
misinterpretation of the LED sub-node properties, where-by "default-state"
was used to indicate the initial state when powering on the device. When in
use, however, this resulted in the amber LED always being on. Instead change
this to only indicate a fault state.

Assign LED_FUNCTION_POWER to the green PWM LED.

These changes bring the MX64/65 in line with the MR32's devicetree.

Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi
arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi
arch/arm/boot/dts/bcm958625-meraki-mx6x-common.dtsi

index ba01054a76cfe7731e49436ad4ee27fc6adce5c9..58b7d9fc7574350bdeb5ca74acc130e9eb6452cd 100644 (file)
 
                led-4 {
                        /* amber:power */
-                       function = LED_FUNCTION_POWER;
+                       function = LED_FUNCTION_FAULT;
                        color = <LED_COLOR_ID_AMBER>;
                        gpios = <&gpioa 3 GPIO_ACTIVE_HIGH>;
-                       default-state = "on";
                };
 
                led-5 {
index 7c487c74fd102571c4b0c2be99790e9b684682a2..576cfc52567b3e4a92fa8caa14dc132bdb47c959 100644 (file)
 
                led-a {
                        /* amber:power */
-                       function = LED_FUNCTION_POWER;
+                       function = LED_FUNCTION_FAULT;
                        color = <LED_COLOR_ID_AMBER>;
                        gpios = <&gpioa 0 GPIO_ACTIVE_LOW>;
-                       default-state = "on";
                };
 
                led-b {
index 5de727de6a4b5622c12329dd56f2b4a0309d882f..b0854d881ac6801f048395a5325b198ceb24423e 100644 (file)
@@ -22,7 +22,7 @@
                };
 
                led-2 {
-                       function = LED_FUNCTION_INDICATOR;
+                       function = LED_FUNCTION_POWER;
                        color = <LED_COLOR_ID_GREEN>;
                        pwms = <&pwm 2 50000>;
                        max-brightness = <255>;