arm64/mm: Enable batched TLB flush in unmap_hotplug_range()

During a memory hot remove operation, both linear and vmemmap mappings for
the memory range being removed, get unmapped via unmap_hotplug_range() but
mapped pages get freed only for vmemmap mapping. This is just a sequential
operation where each table entry gets cleared, followed by a leaf specific
TLB flush, and then followed by memory free operation when applicable.

This approach was simple and uniform both for vmemmap and linear mappings.
But linear mapping might contain CONT marked block memory where it becomes
necessary to first clear out all entire in the range before a TLB flush.
This is as per the architecture requirement. Hence batch all TLB flushes
during the table tear down walk and finally do it in unmap_hotplug_range().

Prior to this fix, it was hypothetically possible for a speculative access
to a higher address in the contiguous block to fill the TLB with shattered
entries for the entire contiguous range after a lower address had already
been cleared and invalidated. Due to the table entries being shattered, the
subsequent TLB invalidation for the higher address would not then clear the
TLB entries for the lower address, meaning stale TLB entries could persist.

Besides it also helps in improving the performance via TLBI range operation
along with reduced synchronization instructions. The time spent executing
unmap_hotplug_range() improved 97% measured over a 2GB memory hot removal
in KVM guest.

This scheme is not applicable during vmemmap mapping tear down where memory
needs to be freed and hence a TLB flush is required after clearing out page
table entry.

Cc: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Closes: https://lore.kernel.org/all/aWZYXhrT6D2M-7-N@willie-the-truck/
Fixes: bbd6ec605c0f ("arm64/mm: Enable memory hot remove")
Cc: stable@vger.kernel.org
Reviewed-by: David Hildenbrand (Arm) <david@kernel.org>
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
index a6a00accf4f9380ca17fa3be2aee6abf17009e12..5dbf988120c8eace0cd9666025f01a979f671651 100644 (file)
--- a/arch/arm64/mm/mmu.c
+++ b/arch/arm64/mm/mmu.c
@@ -1458,10 +1458,14 @@ static void unmap_hotplug_pte_range(pmd_t *pmdp, unsigned long addr,
 
                WARN_ON(!pte_present(pte));
                __pte_clear(&init_mm, addr, ptep);
-               flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
-               if (free_mapped)
+               if (free_mapped) {
+                       /* CONT blocks are not supported in the vmemmap */
+                       WARN_ON(pte_cont(pte));
+                       flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
                        free_hotplug_page_range(pte_page(pte),
                                                PAGE_SIZE, altmap);
+               }
+               /* unmap_hotplug_range() flushes TLB for !free_mapped */
        } while (addr += PAGE_SIZE, addr < end);
 }
 
@@ -1482,15 +1486,14 @@ static void unmap_hotplug_pmd_range(pud_t *pudp, unsigned long addr,
                WARN_ON(!pmd_present(pmd));
                if (pmd_sect(pmd)) {
                        pmd_clear(pmdp);
-
-                       /*
-                        * One TLBI should be sufficient here as the PMD_SIZE
-                        * range is mapped with a single block entry.
-                        */
-                       flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
-                       if (free_mapped)
+                       if (free_mapped) {
+                               /* CONT blocks are not supported in the vmemmap */
+                               WARN_ON(pmd_cont(pmd));
+                               flush_tlb_kernel_range(addr, addr + PMD_SIZE);
                                free_hotplug_page_range(pmd_page(pmd),
                                                        PMD_SIZE, altmap);
+                       }
+                       /* unmap_hotplug_range() flushes TLB for !free_mapped */
                        continue;
                }
                WARN_ON(!pmd_table(pmd));
@@ -1515,15 +1518,12 @@ static void unmap_hotplug_pud_range(p4d_t *p4dp, unsigned long addr,
                WARN_ON(!pud_present(pud));
                if (pud_sect(pud)) {
                        pud_clear(pudp);
-
-                       /*
-                        * One TLBI should be sufficient here as the PUD_SIZE
-                        * range is mapped with a single block entry.
-                        */
-                       flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
-                       if (free_mapped)
+                       if (free_mapped) {
+                               flush_tlb_kernel_range(addr, addr + PUD_SIZE);
                                free_hotplug_page_range(pud_page(pud),
                                                        PUD_SIZE, altmap);
+                       }
+                       /* unmap_hotplug_range() flushes TLB for !free_mapped */
                        continue;
                }
                WARN_ON(!pud_table(pud));
@@ -1553,6 +1553,7 @@ static void unmap_hotplug_p4d_range(pgd_t *pgdp, unsigned long addr,
 static void unmap_hotplug_range(unsigned long addr, unsigned long end,
                                bool free_mapped, struct vmem_altmap *altmap)
 {
+       unsigned long start = addr;
        unsigned long next;
        pgd_t *pgdp, pgd;
 
@@ -1574,6 +1575,9 @@ static void unmap_hotplug_range(unsigned long addr, unsigned long end,
                WARN_ON(!pgd_present(pgd));
                unmap_hotplug_p4d_range(pgdp, addr, next, free_mapped, altmap);
        } while (addr = next, addr < end);
+
+       if (!free_mapped)
+               flush_tlb_kernel_range(start, end);
 }
 
 static void free_empty_pte_table(pmd_t *pmdp, unsigned long addr,