]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
irqchip/riscv-intc: Add missing free() callback in riscv_intc_domain_ops
authorNick Hu <nick.hu@sifive.com>
Fri, 14 Nov 2025 07:28:44 +0000 (15:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Nov 2025 09:35:55 +0000 (10:35 +0100)
[ Upstream commit 14473a1f88596fd729e892782efc267c0097dd1d ]

The irq_domain_free_irqs() helper requires that the irq_domain_ops->free
callback is implemented. Otherwise, the kernel reports the warning message
"NULL pointer, cannot free irq" when irq_dispose_mapping() is invoked to
release the per-HART local interrupts.

Set irq_domain_ops->free to irq_domain_free_irqs_top() to cure that.

Fixes: 832f15f42646 ("RISC-V: Treat IPIs as normal Linux IRQs")
Signed-off-by: Nick Hu <nick.hu@sifive.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://patch.msgid.link/20251114-rv-intc-fix-v1-1-a3edd1c1a868@sifive.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-riscv-intc.c

index f653c13de62b57acdae822fdbed41c881a72ceaa..a02ef98848d36d4f237cf31c7abafa128c6ff747 100644 (file)
@@ -166,7 +166,8 @@ static int riscv_intc_domain_alloc(struct irq_domain *domain,
 static const struct irq_domain_ops riscv_intc_domain_ops = {
        .map    = riscv_intc_domain_map,
        .xlate  = irq_domain_xlate_onecell,
-       .alloc  = riscv_intc_domain_alloc
+       .alloc  = riscv_intc_domain_alloc,
+       .free   = irq_domain_free_irqs_top,
 };
 
 static struct fwnode_handle *riscv_intc_hwnode(void)