]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
uio/uio_pci_generic: remove unneeded pci_set_drvdata()
authorAlexandru Ardelean <alexandru.ardelean@analog.com>
Mon, 23 Nov 2020 14:34:47 +0000 (16:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Dec 2020 18:57:20 +0000 (19:57 +0100)
The pci_get_drvdata() was moved during commit ef84928cff58
("uio/uio_pci_generic: use device-managed function equivalents").

Storing a private object with pci_set_drvdata() doesn't make sense
since that change, since there is no more pci_get_drvdata() call in the
driver to retrieve the information.

This change removes it.

Fixes: ef84928cff58 ("uio/uio_pci_generic: use device-managed function equivalents")
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Link: https://lore.kernel.org/r/20201123143447.16829-1-alexandru.ardelean@analog.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/uio/uio_pci_generic.c

index 1c6c09e1280d2f779298260a88b733072fc27ca1..b8e44d16279fbc0f77c3bf41346eb83d2b163c18 100644 (file)
@@ -101,13 +101,7 @@ static int probe(struct pci_dev *pdev,
                         "no support for interrupts?\n");
        }
 
-       err = devm_uio_register_device(&pdev->dev, &gdev->info);
-       if (err)
-               return err;
-
-       pci_set_drvdata(pdev, gdev);
-
-       return 0;
+       return devm_uio_register_device(&pdev->dev, &gdev->info);
 }
 
 static struct pci_driver uio_pci_driver = {