]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
winbindd: wbint_bh_raw_call_child_done() doesn't have state->domain
authorStefan Metzmacher <metze@samba.org>
Fri, 7 Feb 2025 14:24:50 +0000 (15:24 +0100)
committerRalph Boehme <slow@samba.org>
Sat, 8 Feb 2025 15:26:38 +0000 (15:26 +0000)
Only child or domain binding handles are possible!

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/winbindd/winbindd_dual_ndr.c

index 0b44dbedb085c229e002b160a7d5fc304578909f..219596b9fc03e31ae359a070f64f1ae905899ebb 100644 (file)
@@ -176,11 +176,6 @@ static void wbint_bh_raw_call_child_done(struct tevent_req *subreq)
                return;
        }
 
-       if (state->domain != NULL) {
-               wcache_store_ndr(state->domain, state->opnum,
-                                &state->in_data, &state->out_data);
-       }
-
        tevent_req_done(req);
 }
 
@@ -523,6 +518,9 @@ struct dcerpc_binding_handle *wbint_binding_handle(TALLOC_CTX *mem_ctx,
        struct dcerpc_binding *b = NULL;
        NTSTATUS status;
 
+       SMB_ASSERT((domain != NULL && child == NULL) ||
+                 (domain == NULL && child != NULL));
+
        h = dcerpc_binding_handle_create(mem_ctx,
                                         &wbint_bh_ops,
                                         NULL,