media: v4l: Memset argument to 0 before calling get_mbus_config pad op

[ Upstream commit 91d6a99acfa5ce9f95ede775074b80f7193bd717 ]

Memset the config argument to get_mbus_config V4L2 sub-device pad
operation to zero before calling the operation. This ensures the callers
don't need to bother with it nor the implementations need to set all
fields that may not be relevant to them.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index 5d27a27cc2f2424aaa085652097103078f232d43..6f2267625c7eac79ac699d9a6af19b931976106b 100644 (file)
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -314,6 +314,8 @@ static int call_enum_dv_timings(struct v4l2_subdev *sd,
 static int call_get_mbus_config(struct v4l2_subdev *sd, unsigned int pad,
                                struct v4l2_mbus_config *config)
 {
+       memset(config, 0, sizeof(*config));
+
        return check_pad(sd, pad) ? :
               sd->ops->pad->get_mbus_config(sd, pad, config);
 }

diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index 9a476f902c4259011f103c30830014b24a67339a..262b5e5cebc4cc59d53b3b425b33419d78c7ef90 100644 (file)
--- a/include/media/v4l2-subdev.h
+++ b/include/media/v4l2-subdev.h
@@ -714,7 +714,9 @@ struct v4l2_subdev_state {
  *                  possible configuration from the remote end, likely calling
  *                  this operation as close as possible to stream on time. The
  *                  operation shall fail if the pad index it has been called on
- *                  is not valid or in case of unrecoverable failures.
+ *                  is not valid or in case of unrecoverable failures. The
+ *                  config argument has been memset to 0 just before calling
+ *                  the op.
  *
  * @set_mbus_config: set the media bus configuration of a remote sub-device.
  *                  This operations is intended to allow, in combination with