]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
thermal/of: Assume polling-delay(-passive) 0 when absent
authorKonrad Dybcio <konrad.dybcio@linaro.org>
Thu, 25 Jan 2024 12:11:16 +0000 (13:11 +0100)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 11 Mar 2024 16:14:46 +0000 (17:14 +0100)
Currently, thermal zones associated with providers that have interrupts
for signaling hot/critical trips are required to set a polling-delay
of 0 to indicate no polling. This feels a bit backwards.

Change the code such that "no polling delay" also means "no polling".

Suggested-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20240125-topic-thermal-v1-2-3c9d4dced138@linaro.org
drivers/thermal/thermal_of.c

index bc4b50fce70c8920c14cb137ff91309861153627..aa34b6e82e268bce2cb964ad5fcea02122f046c1 100644 (file)
@@ -227,14 +227,18 @@ static int thermal_of_monitor_init(struct device_node *np, int *delay, int *pdel
        int ret;
 
        ret = of_property_read_u32(np, "polling-delay-passive", pdelay);
-       if (ret < 0) {
-               pr_err("%pOFn: missing polling-delay-passive property\n", np);
+       if (ret == -EINVAL) {
+               *pdelay = 0;
+       } else if (ret < 0) {
+               pr_err("%pOFn: Couldn't get polling-delay-passive: %d\n", np, ret);
                return ret;
        }
 
        ret = of_property_read_u32(np, "polling-delay", delay);
-       if (ret < 0) {
-               pr_err("%pOFn: missing polling-delay property\n", np);
+       if (ret == -EINVAL) {
+               *delay = 0;
+       } else if (ret < 0) {
+               pr_err("%pOFn: Couldn't get polling-delay: %d\n", np, ret);
                return ret;
        }