]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hinic3: add WQ_PERCPU to alloc_workqueue users
authorMarco Crivellari <marco.crivellari@suse.com>
Tue, 13 Jan 2026 15:14:33 +0000 (16:14 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 16 Jan 2026 03:54:41 +0000 (19:54 -0800)
This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:

   commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
   commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The refactoring is going to alter the default behavior of
alloc_workqueue() to be unbound by default.

With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU. For more details see the Link tag below.

In order to keep alloc_workqueue() behavior identical, explicitly request
WQ_PERCPU.

Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Reviewed-by: Fan Gong <gongfan1@huawei.com>
Link: https://patch.msgid.link/20260113151433.257320-1-marco.crivellari@suse.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/huawei/hinic3/hinic3_eqs.c
drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c

index 01686472985b4cb5907e5a60d0a2358e3816969b..1ecc2aca1e3537d3ff7ae25d2566973507412cc1 100644 (file)
@@ -655,7 +655,7 @@ int hinic3_aeqs_init(struct hinic3_hwdev *hwdev, u16 num_aeqs,
        hwdev->aeqs = aeqs;
        aeqs->hwdev = hwdev;
        aeqs->num_aeqs = num_aeqs;
-       aeqs->workq = alloc_workqueue(HINIC3_EQS_WQ_NAME, WQ_MEM_RECLAIM,
+       aeqs->workq = alloc_workqueue(HINIC3_EQS_WQ_NAME, WQ_MEM_RECLAIM | WQ_PERCPU,
                                      HINIC3_MAX_AEQS);
        if (!aeqs->workq) {
                dev_err(hwdev->dev, "Failed to initialize aeq workqueue\n");
index 95a213133be98c1a51b2975ab909e160569e16d9..3696ab3f1a1b6d240b029d1e86b92ea05745b161 100644 (file)
@@ -472,7 +472,7 @@ int hinic3_init_hwdev(struct pci_dev *pdev)
                goto err_free_hwdev;
        }
 
-       hwdev->workq = alloc_workqueue(HINIC3_HWDEV_WQ_NAME, WQ_MEM_RECLAIM,
+       hwdev->workq = alloc_workqueue(HINIC3_HWDEV_WQ_NAME, WQ_MEM_RECLAIM | WQ_PERCPU,
                                       HINIC3_WQ_MAX_REQ);
        if (!hwdev->workq) {
                dev_err(hwdev->dev, "Failed to alloc hardware workq\n");