]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: hotplug: Add warning regarding SD hotplug
authorPeter Krempa <pkrempa@redhat.com>
Mon, 11 Jun 2018 11:36:56 +0000 (13:36 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 10 Jul 2018 11:32:54 +0000 (13:32 +0200)
SD card hotplug should not be implemented until they can be used via
-blockdev.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_hotplug.c

index 23f6d1dabab250350d41095268089e914ab8bc75..69f599f5753c22cbe1890507e596dc5aa6c2b25a 100644 (file)
@@ -725,6 +725,9 @@ qemuDomainAttachDeviceDiskLive(virQEMUDriverPtr driver,
         case VIR_DOMAIN_DISK_BUS_UML:
         case VIR_DOMAIN_DISK_BUS_SATA:
         case VIR_DOMAIN_DISK_BUS_SD:
+            /* Note that SD card hotplug support should be added only once
+             * they support '-device' (don't require -drive only).
+             * See also: qemuDiskBusNeedsDriveArg */
         case VIR_DOMAIN_DISK_BUS_LAST:
             virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                            _("disk bus '%s' cannot be hotplugged."),