]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ksmbd: Replace one-element array with flexible-array member
authorGustavo A. R. Silva <gustavoars@kernel.org>
Sun, 31 Dec 2023 07:12:50 +0000 (16:12 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jan 2024 14:18:31 +0000 (15:18 +0100)
[ Upstream commit 11d5e2061e973a8d4ff2b95a114b4b8ef8652633 ]

One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element array with flexible-array
member in struct smb_negotiate_req.

This results in no differences in binary output.

Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/317
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/server/smb_common.h

index f0134d16067fbc924467dc888ce08783b1629376..f1092519c0c288223b1ad7d2e66e9545fc5bcac3 100644 (file)
@@ -200,7 +200,7 @@ struct smb_hdr {
 struct smb_negotiate_req {
        struct smb_hdr hdr;     /* wct = 0 */
        __le16 ByteCount;
-       unsigned char DialectsArray[1];
+       unsigned char DialectsArray[];
 } __packed;
 
 struct smb_negotiate_rsp {