]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
SCRIPTS: git-show-backports: add missing quotes to "echo"
authorWilly Tarreau <w@1wt.eu>
Mon, 30 Jul 2018 12:45:55 +0000 (14:45 +0200)
committerWilly Tarreau <w@1wt.eu>
Mon, 30 Jul 2018 12:45:55 +0000 (14:45 +0200)
Two places were not properly protected, resulting in '*' in commit
subjects being interpreted!

scripts/git-show-backports

index 15697016af10d21e387693e89ba1aa753a521317..ab44eaf1be21d46567488248f5ec9acc6c2de312 100755 (executable)
@@ -132,7 +132,7 @@ dump_commit_matrix() {
                done
                line="${line} |"
                if [ -z "$MISSING" -o $missing -gt 0 ]; then
-                       [ $((count++)) -gt 0 ] || echo $title
+                       [ $((count++)) -gt 0 ] || echo "$title"
                        [ "$QUIET" != "" -o $count -lt 20 ] || count=0
                        if [ -z "$UPSTREAM" -o "$upstream" = "none" -o -z "$upstream" ]; then
                                echo "$(short $ref) $line"
@@ -235,7 +235,7 @@ dump_commit_matrix | column -t | \
                        echo "---- Subject ----"
                else
                        # doing it this way prevents git from abusing the terminal
-                       echo $(git log -1 --pretty="%s" "$1")
+                       echo "$(git log -1 --pretty="%s" "$1")"
                        left_commits[${#left_commits[@]}]="$1"
                        comm=""
                        while [ -n "$1" -a "$1" != "-" -a "$1" != "|" ]; do