]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
binder: log transaction code on failure
authorCarlos Llamas <cmllamas@google.com>
Fri, 10 Jan 2025 17:50:50 +0000 (17:50 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Jan 2025 05:18:47 +0000 (06:18 +0100)
When a transaction fails, log the 'tr->code' to help indentify the
problematic userspace call path. This additional information will
simplify debugging efforts.

Cc: Steven Moreland <smoreland@google.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Link: https://lore.kernel.org/r/20250110175051.2656975-1-cmllamas@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binder.c

index 91e184ca46d1f30e5a0a784a4579c3f6bb279111..d6def6caf9506acad76154218915f0f4ab01caf7 100644 (file)
@@ -3801,13 +3801,13 @@ err_invalid_target_handle:
        }
 
        binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
-                    "%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n",
+                    "%d:%d transaction %s to %d:%d failed %d/%d/%d, code %u size %lld-%lld line %d\n",
                     proc->pid, thread->pid, reply ? "reply" :
                     (tr->flags & TF_ONE_WAY ? "async" : "call"),
                     target_proc ? target_proc->pid : 0,
                     target_thread ? target_thread->pid : 0,
                     t_debug_id, return_error, return_error_param,
-                    (u64)tr->data_size, (u64)tr->offsets_size,
+                    tr->code, (u64)tr->data_size, (u64)tr->offsets_size,
                     return_error_line);
 
        if (target_thread)