]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
megaraid_sas: remove sysfs poll_mode_io world writeable permissions
authorBryn M. Reeves <bmr@redhat.com>
Thu, 12 Nov 2009 18:31:54 +0000 (18:31 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 1 Apr 2010 22:55:33 +0000 (15:55 -0700)
commit bb7d3f24c71e528989501617651b669fbed798cb upstream.

/sys/bus/pci/drivers/megaraid_sas/poll_mode_io defaults to being
world-writable, which seems bad (letting any user affect kernel driver
behavior).

This turns off group and user write permissions, so that on typical
production systems only root can write to it.

Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/megaraid/megaraid_sas.c

index 7a838c8462de4b4855117f2dde68f6233c80e40c..4352e30cd1f66d9f7cc0e164945d9b6572ee55d1 100644 (file)
@@ -3451,7 +3451,7 @@ out:
        return retval;
 }
 
-static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUGO,
+static DRIVER_ATTR(poll_mode_io, S_IRUGO|S_IWUSR,
                megasas_sysfs_show_poll_mode_io,
                megasas_sysfs_set_poll_mode_io);