power: supply: max1720x: fix a double free on error in probe()

In this code, if devm_add_action_or_reset() fails, it will call
max1720x_unregister_ancillary() which in turn calls
i2c_unregister_device().  Thus the call to i2c_unregister_device() on the
following line is not required and is a double unregister.  Delete it.

Fixes: 47271a935619 ("power: supply: max1720x: add read support for nvmem")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/9c2f76e7-5679-473b-9b9c-e11b492b96ac@stanley.mountain
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

diff --git a/drivers/power/supply/max1720x_battery.c b/drivers/power/supply/max1720x_battery.c
index 3e84e70340e422fd847f2624ba026948f716a85c..2bc3dce963a3ab178ceb68f6cc1676bca96425d1 100644 (file)
--- a/drivers/power/supply/max1720x_battery.c
+++ b/drivers/power/supply/max1720x_battery.c
@@ -427,7 +427,6 @@ static int max1720x_probe_nvmem(struct i2c_client *client,
 
        ret = devm_add_action_or_reset(dev, max1720x_unregister_ancillary, info);
        if (ret) {
-               i2c_unregister_device(info->ancillary);
                dev_err(dev, "Failed to add unregister callback\n");
                return ret;
        }