IMAP AUTHENTICATE and POP3 AUTH commands could have left the process stuck

doing nothing forever.

--HG--
branch : HEAD

diff --git a/src/imap-login/client-authenticate.c b/src/imap-login/client-authenticate.c
index f285ac9acf5468c8ebc6099096649d86793e355e..f01f7ef48c05904028374174405c571e7e07ad9d 100644 (file)
--- a/src/imap-login/client-authenticate.c
+++ b/src/imap-login/client-authenticate.c
@@ -241,8 +241,10 @@ static void client_auth_input(void *context)
        char *line;
        size_t linelen, bufsize;
 
-       if (!client_read(client))
+       if (!client_read(client)) {
+               client_unref(client);
                return;
+       }
 
        if (client->skip_line) {
                if (i_stream_next_line(client->input) == NULL)

diff --git a/src/pop3-login/client-authenticate.c b/src/pop3-login/client-authenticate.c
index ca7f849a2e5524906301d75802693ced7ad9e44a..6f5203ea69b5796fd18898f8d3a85301132c77d9 100644 (file)
--- a/src/pop3-login/client-authenticate.c
+++ b/src/pop3-login/client-authenticate.c
@@ -237,8 +237,10 @@ static void client_auth_input(void *context)
        char *line;
        size_t linelen, bufsize;
 
-       if (!client_read(client))
+       if (!client_read(client)) {
+               client_unref(client);
                return;
+       }
 
        /* @UNSAFE */
        line = i_stream_next_line(client->input);